Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(external_link): optimize regex #4790

Merged
merged 1 commit into from
Oct 8, 2021
Merged

perf(external_link): optimize regex #4790

merged 1 commit into from
Oct 8, 2021

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Oct 2, 2021

What does it do?

Even faster regexp (more strict)

How to test

git clone -b external_link_regex https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.136% when pulling e4c5f5f on SukkaW:external_link_regex into 9edbc99 on hexojs:master.

@SukkaW SukkaW merged commit 098cf0a into hexojs:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SukkaW @coveralls @stevenjoezhang