Skip to content
This repository has been archived by the owner on Aug 25, 2022. It is now read-only.

Brew upgrade leads to confusing hhvm state #137

Open
bigfootjon opened this issue Jun 19, 2020 · 4 comments
Open

Brew upgrade leads to confusing hhvm state #137

bigfootjon opened this issue Jun 19, 2020 · 4 comments

Comments

@bigfootjon
Copy link
Member

bigfootjon commented Jun 19, 2020

It would be nice if hhvm and hhvm-x.x were separate packages instead of aliasing hhvm to the latest version, as this alias breaks when homebrew is upgraded.

For example:

  • brew install hhvm installs hhvm-4.61
  • Wait for hhvm 4.62 to be released
  • brew upgrade
  • hhvm --version indicates that I'm still on 4.61
  • ???

It's especially confusing to try and rectify the situation after a brew upgrade as brew uninstall hhvm complains that I don't have hhvm-4.62 installed which is... correct but not a helpful error message.

My workaround is to brew uninstall hhvm && brew upgrade && brew install hhvm which is annoying and takes more time. If I forget to uninstall before upgrading it's brew uninstall hhvm-4.61 && brew install hhvm. Since HHVM has such a frequent release cadence trying to keep up-to-date with homebrew in this way is a bit tiresome.

@jjergus
Copy link
Contributor

jjergus commented Jun 25, 2020

This sounds reasonable to me and probably a simple change (possibly just change ln -sf ... to cp ... in the build script?) but I don't know a lot about Homebrew, @fredemmott what do you think?

@fredemmott
Copy link
Contributor

This is a good change; I didn't think it was that trivial because of $problems_we've_already_solved_to_make_the_symlink_updating_working

@fredemmott
Copy link
Contributor

oh, this might need a rebuild actually - the package name is part of the binary package filename

@fredemmott
Copy link
Contributor

Yeah, there's a bunch of metadata, we can't just re-use the existing build artifact

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants