New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader response http headers propagation on SSR? #62

Open

hi-ogawa opened this issue Jul 16, 2023 · 0 comments

Owner

hi-ogawa commented Jul 16, 2023 •

edited

cf.

vite-plugins/packages/demo/src/server/index.tsx

Lines 52 to 55 in a803d1c

    
           // TODO: apply server loader headers? 
        
           // remix employs `export const header = ...` 
        
           // https://github.com/remix-run/remix/blob/8268142371234795491070bafa23cd4607a36529/packages/remix-server-runtime/headers.ts#L65-L76 
        
           routerResult.context.loaderHeaders;

Providing convention for this would be too opinionated, so probably just providing a few utilities at best.

hi-ogawa changed the title ~~loader response http headers propagation~~ loader response http headers propagation?

hi-ogawa changed the title ~~loader response http headers propagation?~~ loader response http headers propagation on SSR?

hi-ogawa mentioned this issue

feat(glob-routes): improve loader feature #49

Closed

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment