Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] customize serializer #873

Open
cold-bin opened this issue Apr 29, 2024 · 0 comments
Open

[FEATURE REQUEST] customize serializer #873

cold-bin opened this issue Apr 29, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@cold-bin
Copy link

Is your feature request related to a problem? Please describe.
I want to customize serializer, need a defined interface in order to better readability or better performance

// EncodeSchedulerEnqueueEvent marshals the given event
// and returns an encoded bytes.
func EncodeSchedulerEnqueueEvent(event *SchedulerEnqueueEvent) ([]byte, error) {
	if event == nil {
		return nil, fmt.Errorf("cannot encode nil enqueue event")
	}
	enqueuedAt, err := ptypes.TimestampProto(event.EnqueuedAt)
	if err != nil {
		return nil, err
	}
	return proto.Marshal(&pb.SchedulerEnqueueEvent{
		TaskId:      event.TaskID,
		EnqueueTime: enqueuedAt,
	})
}

Describe the solution you'd like

type Serializer interface{
  func Marshal(v any) ([]byte, error)
  func Unmarshal(data []byte, v any) error
}

so that, I can write my serializer.

@cold-bin cold-bin added the enhancement New feature or request label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants