From 187e7cfcb06277ce13b5f35fb6c37ab7a7b46de9 Mon Sep 17 00:00:00 2001
From: Josh Goebel <me@joshgoebel.com>
Date: Mon, 12 Oct 2020 17:04:53 -0400
Subject: [PATCH] remove unsupported negative lookbehind regex

- cherry pick from unreleased branch
---
 src/languages/r.js | 35 ++++++++++++++++++++++++++++++-----
 1 file changed, 30 insertions(+), 5 deletions(-)

diff --git a/src/languages/r.js b/src/languages/r.js
index 176e2075a7..b095333004 100644
--- a/src/languages/r.js
+++ b/src/languages/r.js
@@ -126,15 +126,40 @@ export default function(hljs) {
           {begin: "'", end: "'", relevance: 0}
         ],
       },
-
       {
         className: 'number',
         variants: [
-          // Special case: only hexadecimal binary powers can contain fractions.
-          { begin: /(?<![a-zA-Z0-9._])0[xX][0-9a-fA-F]+\.[0-9a-fA-F]*[pP][+-]?\d+i?/ },
-          { begin: /(?<![a-zA-Z0-9._])0[xX][0-9a-fA-F]+([pP][+-]?\d+)?[Li]?/ },
-          { begin: /(?<![a-zA-Z0-9._])(\d+(\.\d*)?|\.\d+)([eE][+-]?\d+)?[Li]?/ }
+          // TODO: replace with negative look-behind when available
+          // { begin: /(?<![a-zA-Z0-9._])0[xX][0-9a-fA-F]+\.[0-9a-fA-F]*[pP][+-]?\d+i?/ },
+          // { begin: /(?<![a-zA-Z0-9._])0[xX][0-9a-fA-F]+([pP][+-]?\d+)?[Li]?/ },
+          // { begin: /(?<![a-zA-Z0-9._])(\d+(\.\d*)?|\.\d+)([eE][+-]?\d+)?[Li]?/ }
+
+          // The below rules all eat an extra character in front (for the
+          // look-behind check) and then exclude it from the match, but I think
+          // in many cases this will work out just fine.
+          {
+            // Special case: only hexadecimal binary powers can contain fractions.
+            begin: /([^a-zA-Z0-9._])(?=0[xX][0-9a-fA-F]+\.[0-9a-fA-F]*[pP][+-]?\d+i?)/,
+            end: /0[xX][0-9a-fA-F]+\.[0-9a-fA-F]*[pP][+-]?\d+i?/,
+            excludeBegin: true
+          },
+          {
+            begin: /([^a-zA-Z0-9._])(?=0[xX][0-9a-fA-F]+([pP][+-]?\d+)?[Li]?)/,
+            end: /0[xX][0-9a-fA-F]+([pP][+-]?\d+)?[Li]?/ ,
+            excludeBegin: true
+          },
+          {
+            begin: /([^a-zA-Z0-9._])(?=(\d+(\.\d*)?|\.\d+)([eE][+-]?\d+)?[Li]?)/,
+            end: /(\d+(\.\d*)?|\.\d+)([eE][+-]?\d+)?[Li]?/,
+            excludeBegin: true
+          }
         ],
+        // "on:begin": (match, response) => {
+        //   if (match.index > 0) {
+        //     let priorChar = match.input[match.index - 1];
+        //     if (priorChar.match(/[a-zA-Z0-9._]/)) response.ignoreMatch();
+        //   }
+        // },
         relevance: 0
       },