Pony markup tests #1958
Merged
Pony markup tests #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @gregcline, this looks fine for me. |
|
@egor-rogov i reviewed before he opened the PR. Looks good to me. |
egor-rogov
approved these changes
Jan 29, 2019
|
Okay then. Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #1932 I added some markup tests for Pony.
I also made a couple adjustments to highlighting for classes and functions. I added
primitiveto the list of beginning keywords for class highlighting and made the class name highlight the same as other type names.isis also now highlighted as a keyword in class definitions.The only change I made to functions was including
bein the beginning keywords.