Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ini/toml: Support comments on the same line. #2039

Merged
merged 2 commits into from May 29, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented May 23, 2019

TOML supports comments on the end of the line:

x = 1 # comment on same line

And AFAIK, ini files tend to support it as well.

x = 1 ; comment

@tesuji
Copy link

tesuji commented May 24, 2019

This should fix #2040 .

Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want a test for each.

@ehuss
Copy link
Contributor Author

ehuss commented May 28, 2019

I've added some tests for ini/toml. There weren't any before, so I added some coverage of the basic syntax. Not sure how you prefer things to work or be organized, I could merge them into one test.

Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look great. thanks for adding the additional tests!

@marcoscaceres marcoscaceres merged commit 7af498f into highlightjs:master May 29, 2019
@marcoscaceres
Copy link
Contributor

Not sure how you prefer things to work or be organized, I could merge them into one test.

It's fine as it is... made sure the commit message covers both ini and toml.

@tesuji
Copy link

tesuji commented May 29, 2019

@marcoscaceres I'm curious. When will the next release happen?
We need it for mdbook to update.

@marcoscaceres
Copy link
Contributor

ok, let me try to get out one now.

@marcoscaceres
Copy link
Contributor

ok, 9.15.7 is out 🥳

@tesuji
Copy link

tesuji commented May 29, 2019

Thank you very much. We'll try to update soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants