New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ini/toml: Support comments on the same line. #2039
Conversation
This should fix #2040 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want a test for each.
I've added some tests for ini/toml. There weren't any before, so I added some coverage of the basic syntax. Not sure how you prefer things to work or be organized, I could merge them into one test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look great. thanks for adding the additional tests!
It's fine as it is... made sure the commit message covers both ini and toml. |
@marcoscaceres I'm curious. When will the next release happen? |
ok, let me try to get out one now. |
ok, 9.15.7 is out 🥳 |
Thank you very much. We'll try to update soon. |
TOML supports comments on the end of the line:
And AFAIK, ini files tend to support it as well.