Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ruby's squiggly heredoc #2049

Merged
merged 4 commits into from Aug 11, 2019

Conversation

skyfmmf
Copy link
Contributor

@skyfmmf skyfmmf commented May 31, 2019

Ruby has the squiggly heredoc notation to insert indented multiline
strings. This should be supported in addition to the existing heredoc
notation.

skyfmmf and others added 4 commits May 31, 2019 21:19
Ruby has the squiggly heredoc notation to insert indented multiline
strings. This should be supported in addition to the existing heredoc
notation.
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that heredoc ends at the first line containing a single word, no matter which one. I changed it so that the closing tag must match the open tag.
(Still it's not ideal, e. g. two heredocs in one line won't get highlighted correctly.)

@egor-rogov egor-rogov merged commit 0b6c4ba into highlightjs:master Aug 11, 2019
@egor-rogov
Copy link
Collaborator

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants