Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support css custom properties #2082

Merged
merged 1 commit into from Jul 31, 2019
Merged

Support css custom properties #2082

merged 1 commit into from Jul 31, 2019

Conversation

colomolo
Copy link
Contributor

@colomolo colomolo commented Jul 31, 2019 •
edited

Support custom properties syntax:

.selector {
  --heading-1: 30px/32px Helvetica, sans-serif;
}

Since css vars have the same naming rules as selectors, digits could be used in naming.

Proofs:
https://drafts.csswg.org/css-variables-1/#custom-property
https://drafts.csswg.org/css-syntax-3/#identifier
https://drafts.csswg.org/css-syntax-3/#ident-token-diagram

egor-rogov
egor-rogov approved these changes Jul 31, 2019
View reviewed changes
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@egor-rogov egor-rogov merged commit 777a2d2 into highlightjs:master Jul 31, 2019
@egor-rogov
Copy link
Collaborator

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egor-rogov egor-rogov egor-rogov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colomolo @egor-rogov