(twig) update list of filter and tags #2090
Conversation
|
@javiereguiluz could you please check why TravisCI is failing? |
|
Looks like this change causes the related test for this language to fail... @javiereguiluz or @weaverryan could you please update the test to reflect the new output. |
|
I'll need some help trying to fix the tests. I can't even run the test on my machine: |
|
@javiereguiluz, You can also look into Travis job log (Details link to the right of "The Travis CI build failed" message). It shows that |
|
@javiereguiluz Can you look into the failing tests and provide an updated PR? |
|
@javiereguiluz Still around? Ping. |
src/languages/twig.js
Outdated
| 'merge nl2br number_format raw replace reverse round slice sort split ' + | ||
| 'striptags title trim upper url_encode', | ||
| 'abs batch capitalize column convert_encoding date date_modify default ' + | ||
| 'escape filter first format inky inline_css join json_encode keys last ' + |
There was a problem hiding this comment.
And does inky stay as deprecated?
There was a problem hiding this comment.
Good point. We could do either: inky is deprecated... but it was from such a new feature, that it only existed for some months before being deprecated. Having it or removing it - both are probably fine.
|
@weaverryan Any chance you have the motivation to jump in here and push this to competition? You could branch from this branch and just lay the tiny changes you need to fix the relevancy on top and make a new PR. |
|
@yyyc514 I'm really sorry for not having replied to your messages. I did the the changes proposed by Ryan. Let's see if it fixes the issues. Thanks. |
joshgoebel
changed the title
src/languages/twig.js
Outdated
| contains: [ | ||
| FUNCTIONS | ||
| ] | ||
| }; | ||
|
|
||
| var TAGS = 'autoescape block do embed extends filter flush for ' + | ||
| 'if import include macro sandbox set spaceless use verbatim'; | ||
| var TAGS = 'apply autoescape block deprecated do embed extends filter flush for from' + |
There was a problem hiding this comment.
So you broke the if endif tags...
|
@javiereguiluz Thanks so much for contributing! Sorry it took so long to get to this! |
|
This should go out in 9.15.11 over the weekend. |
|
@yyyc514 thanks a lot for merging this! I apologize again for not having replied to your requests on time. Cheers! |
Updated according to the latest Twig documentation which can be found here: https://twig.symfony.com/doc/2.x/