Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crystal): correctly highlight !~ after def #2222

Merged
merged 2 commits into from Oct 25, 2019

Conversation

makenowjust
Copy link
Contributor

It is simple edge case fix.

For example, this code:

def !~
end

is currently highlighted as:

<span class="hljs-function"><span class="hljs-keyword">def</span> !<span class="hljs-title">~</span></span>(other)
<span class="hljs-keyword">end</span>

But correct highlight is:

<span class="hljs-function"><span class="hljs-keyword">def</span> <span class="hljs-title">!~</span></span>(other)
<span class="hljs-keyword">end</span>

Thank you.

@joshgoebel
Copy link
Member

joshgoebel commented Oct 25, 2019

Oh Crystal doesn't have an param highlighting or anything, interesting.

@makenowjust Thanks for the contribution, looks good. This'll make the release in a few days.

@joshgoebel joshgoebel self-requested a review October 25, 2019 04:57
@joshgoebel joshgoebel merged commit 0326596 into highlightjs:master Oct 25, 2019
@makenowjust makenowjust deleted the fix-crystal-def branch October 25, 2019 05:03
@joshgoebel joshgoebel added enhancement An enhancement or new feature language labels Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants