Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(makefile) fix double relevance for assignments #2278

Merged

Conversation

joshgoebel
Copy link
Member

Closes #1976.

  • Makefile was claiming 2 relevance for every x = pattern
  • This is a little ridiculous IMHO.
  • I'm not sure any other grammars get points for assignment,
    so 2 seems way off to me.
  • Cleaning up the grammar and lowering this rule back to
    1 relevance.

Closes highlightjs#1976.

- Makefile was claiming 2 relevance for every `x =` pattern
- This is a little ridiculous IMHO.
- I'm not sure any other grammars get points for assignment,
  so 2 seems way off to me.
- Cleaning up the grammar and lowering this rule back to
  1 relevance.
@joshgoebel joshgoebel added language enhancement An enhancement or new feature auto-detect Issue with auto detection of language type labels Nov 12, 2019
@joshgoebel joshgoebel added this to the 9.17 milestone Nov 12, 2019
@joshgoebel joshgoebel added this to In Progress in Highlight.js via automation Nov 12, 2019
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@joshgoebel joshgoebel merged commit b53e78e into highlightjs:master Nov 13, 2019
Highlight.js automation moved this from In Progress to Done Nov 13, 2019
@joshgoebel joshgoebel deleted the fix_makefile_double_assignment_points branch December 6, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-detect Issue with auto detection of language type enhancement An enhancement or new feature language
Projects
No open projects
Highlight.js
  
Done
Development

Successfully merging this pull request may close these issues.

Python recognized as Makefile
2 participants