Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser/docs): disallow self mode at the top-level of a language #2294

Merged
merged 3 commits into from Nov 22, 2019
Merged

fix(parser/docs): disallow self mode at the top-level of a language #2294

merged 3 commits into from Nov 22, 2019

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Nov 21, 2019 •
edited

Closes #2263.

@joshgoebel joshgoebel added enhancement An enhancement or new feature bug parser labels Nov 21, 2019
@joshgoebel joshgoebel merged commit d67e03f into highlightjs:master Nov 22, 2019
@joshgoebel joshgoebel deleted the self_top_level_no_no branch December 6, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egor-rogov egor-rogov egor-rogov approved these changes

Assignees
No one assigned
Labels
bug enhancement An enhancement or new feature parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(fix) contains self pointing to a top-level rule breaks
2 participants
@joshgoebel @egor-rogov