Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(themes) Standardize the padding/spacing for all themes #2300

Merged
merged 5 commits into from Nov 29, 2019

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Nov 23, 2019

It's very weird that 2-3 of our themes completely change the padding/text-layout. I understand why the "school paper" one does, but otherwise our themes should be consistent when it comes to whitespace.

This standardizes on:

  display: block;
  overflow-x: auto;
  padding: 0.5em;

Only 3 themes were changed to bring all our themes into alignment.

  display: block;
  overflow-x: auto;
  padding: 0.5em;

- Update Atom One Dark (reasonable)
- Update Hopscotch
- Update Shades of Purple
- Didn't touch any things with custom backgrounds
@joshgoebel
Copy link
Member Author

@egor-rogov We have some themes that specify no BG color... that seems very weird to me... if they are intended to be light themes would it hurt to add white?

If they are actually intended to be transparent then I think we should specify that explicitly. Thoughts?

@joshgoebel
Copy link
Member Author

Screen Shot 2019-11-25 at 1 34 55 PM

Example of issue on our demo site... if it's intended to be transparent it's not obvious in demo so we'd have to think of a way to indicate that?

Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what's stated in https://highlightjs.readthedocs.io/en/latest/style-guide.html

As for transparent backgrounds, I honestly have no idea.

@joshgoebel
Copy link
Member Author

joshgoebel commented Nov 29, 2019

Exactly what's stated in https://highlightjs.readthedocs.io/en/latest/style-guide.html

Ha, convenient. :) I hadn't seen that.

As for transparent backgrounds, I honestly have no idea.

We'll solve that another day then.

@joshgoebel joshgoebel merged commit 4ba3b91 into highlightjs:master Nov 29, 2019
@joshgoebel joshgoebel deleted the theme_consistency branch December 6, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants