Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(javascript) highlight class methods #2727

Merged

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Oct 3, 2020

Resolved #1987. Never say never.

Doesn't deal with the edge case that TECHNICALLY blah() {} could be a function call FOLLOWED by a block as this is a very unusual coding style.

  • Also changes "constructor" to be a function/title rather than a keyword

src/languages/javascript.js Outdated Show resolved Hide resolved
src/languages/javascript.js Outdated Show resolved Hide resolved
@joshgoebel
Copy link
Member Author

@egor-rogov Ping.

@joshgoebel joshgoebel added this to the 10.3 milestone Oct 3, 2020
src/languages/javascript.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels right 👍

@joshgoebel joshgoebel merged commit 57b3518 into highlightjs:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(javascript) Member functions are not highlighted in ES6 classes
2 participants