Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo: Multi-class should allow capturing match groups #3095

Closed
joshgoebel opened this issue Apr 1, 2021 · 0 comments · Fixed by #3138
Closed

Todo: Multi-class should allow capturing match groups #3095

joshgoebel opened this issue Apr 1, 2021 · 0 comments · Fixed by #3138
Assignees
Labels
enhancement An enhancement or new feature help welcome Could use help from community parser
Projects
Milestone

Comments

@joshgoebel
Copy link
Member

Is your request related to a specific problem you're having?

#3081

Multi-class support does not currently allow capturing match groups. This should be allowed.

The solution you'd prefer / feature you'd like to see added...

We should count the match groups, renumber them, and also renumber the keys passed to className (to account for any new "gaps" that the capture groups have introduced). We have most of the code for this in regex.js already since we have to do a lot of this for our MultiRegexMatcher.

Any alternative solutions you considered...

None.

Additional context...

None.

@joshgoebel joshgoebel added enhancement An enhancement or new feature help welcome Could use help from community parser labels Apr 1, 2021
@joshgoebel joshgoebel self-assigned this Apr 13, 2021
@joshgoebel joshgoebel added this to the 11.0 milestone Apr 13, 2021
@joshgoebel joshgoebel added this to To Do in Version 11 Apr 14, 2021
@joshgoebel joshgoebel moved this from To Do to Waiting merge/review in Version 11 Apr 14, 2021
Version 11 automation moved this from Waiting merge/review to Done Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature help welcome Could use help from community parser
Projects
Development

Successfully merging a pull request may close this issue.

1 participant