Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency to latest highlight.js 10.7.2 #16

Open
akollegger opened this issue Apr 13, 2021 · 13 comments
Open

Bump dependency to latest highlight.js 10.7.2 #16

akollegger opened this issue Apr 13, 2021 · 13 comments

Comments

@akollegger
Copy link

@Mogztter Could you update this dependency? Back-tracking from a problem on community.neo4j.com, where the host has updated to the latest release, causing our theme to break.

Thank you!

-ABK

@joshgoebel
Copy link
Member

joshgoebel commented Apr 13, 2021

@akollegger Could I get a link to a GitHub issue or a thread of this problem? Minor versions don't typically "break" themes - though sometimes highlighting does change slightly - which could require a theme to be updated. Otherwise I'm also not sure how bumping a dependency here would have any effect on your theme at all?

@joshgoebel
Copy link
Member

  "highlightjs": "^9.10.0",

Ok, that is OLD... all bets are off... I take back what I said. :-) it's possible something may indeed need to change if this hasn't been updated since version 9.

@gusbemacbe
Copy link
Collaborator

I'll fix it this afternoon. Please forgive us for the inconvenience.

@joshgoebel
Copy link
Member

Still quite curious how a theme was broken though, grammar itself looks pretty clean - so surprises.

@akollegger
Copy link
Author

The break surfaced as an unsatisfied dependency. It appeared that highlightjs-cypher requires highlightjs but the newer version is highlight.js.

@joshgoebel
Copy link
Member

It appeared that highlightjs-cypher requires highlightjs but the newer version is highlight.js.

Ah yes the correct package name is now highlight.js, the older name was deprecated a year or more ago.

@gusbemacbe
Copy link
Collaborator

Done, @akollegger and @joshgoebel.

@ggrossetie
Copy link
Contributor

Thanks @gusbemacbe !
I think we should probably release version 2.0.0 since it's a major bump? What do you think?

@gusbemacbe
Copy link
Collaborator

Thanks @gusbemacbe !
I think we should probably release version 2.0.0 since it's a major bump? What do you think?

Do you mean to create a new release here?

@ggrossetie
Copy link
Contributor

Do you mean to create a new release here?

Actually, it's a development dependency so I'm a bit confused...

The break surfaced as an unsatisfied dependency. It appeared that highlightjs-cypher requires highlightjs but the newer version is highlight.js.

@akollegger could you please post the complete error message?

@akollegger
Copy link
Author

Apologies, you're right that the dependency was not the root cause for my theme. The theme initialization api changed, which incidentally failed on requiring highlightjs-cypher but had to do with asset loading and not a problem with highlightjs-cypher itself.

-ABK

@joshgoebel
Copy link
Member

The theme initialization api changed,

I wasn't aware we have any sort of API for themes?

@AdamRaichu
Copy link

Outdated issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants