Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom package only minified version is custom #18

Open
pandrr opened this issue Nov 16, 2022 · 5 comments
Open

custom package only minified version is custom #18

pandrr opened this issue Nov 16, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@pandrr
Copy link

pandrr commented Nov 16, 2022

Describe the issue/behavior that seems buggy

first: thanks for the great work, appreciate it !

when creating a custom package on your website, a custom .min.js file is created inside the zip.
the non minified version seems to not contain any languages and has an old file date.

Sample Code or Instructions to Reproduce

  1. goto https://highlightjs.org/download/
  2. click download

Expected behavior

highlight.js contains the selected languages.

Additional context

see filedates in the zip file:

Screenshot 2022-11-16 at 11 26 40

@pandrr pandrr added the bug Something isn't working label Nov 16, 2022
@joshgoebel
Copy link
Member

highlight.js is the stand-alone core library. The only real build asset of custom build is highlight.min.js...

What would be the reasons to include a non-minified custom build?

@pandrr
Copy link
Author

pandrr commented Nov 18, 2022

because in my case i use it to build a bigger file with multiple libs in there and minify them again.

@joshgoebel
Copy link
Member

joshgoebel commented Nov 23, 2022

This seems an edge case to me (for most users) - more custom builds can easily use our official build toolchain... @allejo up to you if you want to add this to the new website or welcome a PR for it.

One problem is we'd have to rejigger the naming, which could break peoples assumptions about the download content.

@joshgoebel
Copy link
Member

@allejo didn't we fix this now?

@janbrasna
Copy link

Fixed in #10 where api/download.ts#L159-L164

  • POST /download returns the old behavior for legacy reasons, but
  • POST /api/download returns the unminified now also concatenated

@joshgoebel joshgoebel transferred this issue from highlightjs/highlight.js Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants