Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jaxb-tools/jaxb-bom to jaxb-tools-bom to not confuse w/ the upstream jaxb-bom #480

Open
2 tasks
mattrpav opened this issue Feb 6, 2024 · 3 comments
Open
2 tasks
Milestone

Comments

@mattrpav
Copy link
Collaborator

mattrpav commented Feb 6, 2024

  • Move jaxb-bom to jaxb-tools-bom
  • Create a Maven relocation for the jaxb-bom artifact
@mattrpav mattrpav modified the milestones: 4.0.3, 4.0.4 Feb 6, 2024
@bschuhmann
Copy link

bschuhmann commented Feb 14, 2024

Apologies to hijack this issue, but while you're looking into jaxb-bom can you maybe fix this:

...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for jakarta.xml.bind:jakarta.xml.bind-api:jar must be a valid version but is '${jaxb-api.version}'. @ org.jvnet.jaxb:jaxb-bom:4.0.3, ~/.m2/repository/org/jvnet/jaxb/jaxb-bom/4.0.3/jaxb-bom-4.0.3.pom, line 24, column 18
...
[ERROR]   The project org.acme:myproject:0.0.1 (~/myproject/pom.xml) has 1 error
[ERROR]     'dependencies.dependency.version' for jakarta.xml.bind:jakarta.xml.bind-api:jar must be a valid version but is '${jaxb-api.version}'. @ org.jvnet.jaxb:jaxb-bom:4.0.3, ~/.m2/repository/org/jvnet/jaxb/jaxb-bom/4.0.3/jaxb-bom-4.0.3.pom, line 24, column 18
...

Not sure if just I'm doing something wrong. But it seems the property jaxb-api.version is used in jaxb-bom/pom.xml but nowhere defined in the project.

🤔 it shouldn't even be necessary to configure jakarta.xml.bind:jakarta.xml.bind-api in jaxb-tools-bom as it's already configured in org.glassfish.jaxb:jaxb-bom, which gets imported in root POM?

@laurentschoelens
Copy link
Collaborator

@bschuhmann could you please provide MRE ?

@laurentschoelens
Copy link
Collaborator

laurentschoelens commented Feb 15, 2024

@bschuhmann : I've seen the error, no MRE needed, we'll look into this.

If needed of jaxb-bom, you can safely use the jaxb-ri one

<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-bom</artifactId>

Or the ext one

<groupId>com.sun.xml.bind</groupId>
<artifactId>jaxb-bom-ext</artifactId>

@mattrpav mattrpav modified the milestones: 4.0.6, 4.0.next Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants