Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higlass as a dependency not compatible with webpack 5 using Node 16 #1103

Open
puehringer opened this issue Jul 7, 2022 · 2 comments
Open

Comments

@puehringer
Copy link

Steps to reproduce

  1. Use Node 16 (and therefore npm 8 where peerDependencies are always installed)
  2. Create a package.json with both higlass and a package requiring webpack 5
  3. Due to unminified-webpack-plugin: ^2.0.0, it will always install webpack 4 on the root level of node_modules

Observed behavior

  • With node_modules/webpack being of version 4, it breaks some scripts which rely on it being on version 5.

Expected behavior

  • It should not at all install unminified-webpack-plugin as dependency, but probably devDependency?

Here, unminified-webpack-plugin is tagged to version ^2.0.0. One could either upgrade to ^3.0.0 (which is webpack 5 only), or move it to devDependencies. Is there a reason why it is included in dependencies instead?

@pkerpedjiev
Copy link
Member

No reason. If you a moment, would you be interested in submitting a PR to fix it?

@pkerpedjiev
Copy link
Member

Actually, would you mind trying the pkerpedjiev/webpack5 branch if you have a moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants