Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 8 #250

Closed
dartess opened this issue Feb 20, 2024 · 15 comments · Fixed by #251
Closed

Storybook 8 #250

dartess opened this issue Feb 20, 2024 · 15 comments · Fixed by #251

Comments

@dartess
Copy link
Contributor

dartess commented Feb 20, 2024

Hi @hipstersmoothie !

Version 8 of Storybook is expected to be released soon, it would be great to know if your addon is ready for an update.

Additional Information:

storybookjs/storybook#25276

https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#from-version-7x-to-800

storybookjs/storybook#26031

@dartess dartess mentioned this issue Feb 20, 2024
@joevaugh4n
Copy link

Thanks for opening up the issue, @dartess!

@vanessayuenn
Copy link

vanessayuenn commented Feb 21, 2024

Thank you @dartess @hipstersmoothie! I see you already opened a PR, but in case this is still helpful, I want to mention that we have an addon migration guide for 8 that summarizes changes relevant to addons specifically.

@joevaugh4n
Copy link

Also @hipstersmoothie – we have an addons channel in the Storybook Discord community, which we’d like to use to better communicate with addon authors in the future.

If you’re not part of the server, consider joining here and message me (@joevaugh4n) so that I can give you the addon creator role! If you’re already in the server, please just ping me and I’ll respond to you there.

Thanks for being a part of our addon community!

@dartess
Copy link
Contributor Author

dartess commented Feb 21, 2024

I'll recheck addon migration guide for 8 soon, thanks.

@dartess
Copy link
Contributor Author

dartess commented Feb 21, 2024

I checked and I think it's ready. I would be grateful for reviews.

@hipstersmoothie
Copy link
Owner

PR looks good. down to merge when v8 comes out

@ItsWendell
Copy link

@hipstersmoothie It would be great if we can publish this as a @next / beta flag like published beta of storybook?

@asvae
Copy link

asvae commented Feb 28, 2024

Just my experience updating to storybook 8. May be useful for someone.

I tried to run npx storybook@next upgrade on existing project per docs recommendation.

I got warning like this:

│   Attention: The following dependencies are duplicated which might cause unexpected behavior:                                                               │
│                                                                                                                                                             │
│   @storybook/types:                                                                                                                                         │
│   8.0.0-beta.5, 7.6.17, 7.0.27                                                                                                                              │
│                                                                                                                                                             │
│   @storybook/channels:                                                                                                                                      │
│   8.0.0-beta.5, 7.6.17, 7.0.27

After I removed "storybook-dark-mode": "^3.0.3" - for both of these packages version settled on 8.0.0-beta.5

@dartess
Copy link
Contributor Author

dartess commented Mar 1, 2024

@ItsWendell @asvae this may be a little tricky but you can test your project now. I use npm, if you use another package manager, then installing the dependency from Github and updating it may be more difficult. But for npm:

  1. remove storybook-dark-mode: npm un storybook-dark-mode
  2. upgrade storybook: npx storybook@next upgrade
  3. install storybook-dark-mode from my branch: npm i -D dartess/storybook-dark-mode#storybook-8
  4. manually copy files .babelrc.js, tsconfig.json and tsconfig.build.json into node_modules/storybook-dark-mode/, go there cd node_modules/storybook-dark-mode/, install deps (npm i), run build (npm run build).
  5. test your app

I would like to update to version 8 as quickly as possible, so I did all this. Everything seems to be working well.

@alkamin
Copy link

alkamin commented Mar 3, 2024

@ItsWendell @asvae this may be a little tricky but you can test your project now. I use npm, if you use another package manager, then installing the dependency from Github and updating it may be more difficult. But for npm:

  1. remove storybook-dark-mode: npm un storybook-dark-mode
  2. upgrade storybook: npx storybook@next upgrade
  3. install storybook-dark-mode from my branch: npm i -D dartess/storybook-dark-mode#storybook-8
  4. manually copy files .babelrc.js, tsconfig.json and tsconfig.build.json into node_modules/storybook-dark-mode/, go there cd node_modules/storybook-dark-mode/, install deps (npm i), run build (npm run build).
  5. test your app

I would like to update to version 8 as quickly as possible, so I did all this. Everything seems to be working well.

Thanks for this. It worked perfectly in my app with SB8.

@joevaugh4n
Copy link

@hipstersmoothie @ItsWendell @dartess @alkamin @asvae thank you all for contributing and testing here! We’re targeting the full release of SB8 on March 11. When the release is live, I’ll write here to confirm!

@C0ZEN
Copy link

C0ZEN commented Mar 13, 2024

@hipstersmoothie it's out 👀

@K3TH3R
Copy link

K3TH3R commented Mar 15, 2024

@hipstersmoothie it's out 👀

With Storybook 8.0.0 and a Vue/Vite setup, I'm seeing the following error:
Screenshot 2024-03-15 at 4 57 28 pm

I've tried just about every possibility I can think of, even completely removing the darkMode key from my parameters object and it always throws this error.

@hipstersmoothie
Copy link
Owner

It's shipped 🍾

@hipstersmoothie
Copy link
Owner

@K3TH3R if that's still an issue open another issue please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants