Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setupApp in VueStoryProps interface is not equal to Vue3StorySetupHandler interface #681

Open
6 tasks done
andrey-hohlov opened this issue Feb 12, 2024 · 0 comments
Open
6 tasks done
Labels
to triage This issue needs to be triaged

Comments

@andrey-hohlov
Copy link

Describe the bug

There is a difference between VueStoryProps['setupApp'] and Vue3StorySetupHandler interfaces. setupApp method doesn't have addWrapper method in it's payload.

Reproduction

<script lang="ts" setup>
import { Vue3StorySetupHandler } from '@histoire/plugin-vue';

const setupApp: Vue3StorySetupHandler = ({ app }) => {
  app.use(/* something */);
};

</script>

<template>
  <Story :setup-app="setupApp">
    <!-- something -->
  </Story>
</template>
error TS2322: Type 'Vue3StorySetupHandler' is not assignable to type '(payload: { app: App<any>; story: Story; variant: Variant; }) => void | Promise<void>'

System Info

System:
    OS: macOS 14.1.2
    CPU: (10) arm64 Apple M1 Max
    Memory: 1.15 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.20.2 - ~/.volta/tools/image/node/16.20.2/bin/node
    npm: 9.6.5 - ~/.volta/tools/image/npm/9.6.5/bin/npm
    pnpm: 8.3.1 - ~/.volta/bin/pnpm
  Browsers:
    Chrome: 121.0.6167.160
    Safari: 17.1.2
  npmPackages:
    @histoire/plugin-vue: ^0.17.6 => 0.17.11 
    @vitejs/plugin-vue: ^4.0.0 => 4.6.2 
    histoire: ^0.17.6 => 0.17.9 
    vite: ^4.5.1 => 4.5.2

Used Package Manager

npm

Validations

@andrey-hohlov andrey-hohlov added the to triage This issue needs to be triaged label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant