Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo is not displaying #700

Open
6 tasks done
fbjorn opened this issue Mar 14, 2024 · 1 comment
Open
6 tasks done

Logo is not displaying #700

fbjorn opened this issue Mar 14, 2024 · 1 comment
Labels
to triage This issue needs to be triaged

Comments

@fbjorn
Copy link

fbjorn commented Mar 14, 2024

Describe the bug

Hi, neither default nor custom logo can't be displayed:

image
image

I bet it's somehow related to SVG resolving, but I'm not sure how to fix it. SVGs within the stories (in my components) work fine.

Reproduction

Vite config:

import { sveltekit } from "@sveltejs/kit/vite"
import { defineConfig } from "vitest/config"
import svg from "@poppanator/sveltekit-svg"

export default defineConfig({
  plugins: [sveltekit(), svg()],
  test: {
    include: ["src/**/*.{test,spec}.{js,ts}"],
  },
})

Histoire config:

import {defineConfig} from "histoire"
import {HstSvelte} from "@histoire/plugin-svelte"

export default defineConfig({
  theme: {
    logo: {
      square: '/src/lib/assets/logos/mylogo.svg',
      light: '/src/lib/assets/logos/mylogo.svg',
      dark: '/src/lib/assets/logos/mylogo.svg',
    },
  },
  setupFile: "/src/stories/_setup.ts",
  plugins: [HstSvelte()],
})

I also tried to add svg() to list of plugins in histoire config, but it did no effect.

System Info

System:
    OS: macOS 14.2.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 519.59 MB / 16.00 GB
    Shell: 3.6.0 - /opt/homebrew/bin/fish
  Binaries:
    Node: 18.19.0 - ~/.local/share/nvm/v18.19.0/bin/node
    npm: 10.2.3 - ~/.local/share/nvm/v18.19.0/bin/npm
    pnpm: 8.7.4 - /opt/homebrew/bin/pnpm
  Browsers:
    Brave Browser: 120.1.61.120
    Chrome: 109.0.5414.87
    Safari: 17.2.1
  npmPackages:
    @histoire/plugin-svelte: ^0.17.9 => 0.17.9 
    histoire: ^0.17.9 => 0.17.9 
    vite: ^5.0.11 => 5.1.4

Used Package Manager

pnpm

Validations

@fbjorn fbjorn added the to triage This issue needs to be triaged label Mar 14, 2024
@50rayn
Copy link
Contributor

50rayn commented Mar 25, 2024

Hello @fbjorn.
Could you please provide e reproduction link (preferably on stackblitz) ? Would be easier and faster for us to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants