Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tslint with typescript-eslint ? #22

Open
dlangerenken opened this issue Feb 17, 2019 · 2 comments
Open

Replace tslint with typescript-eslint ? #22

dlangerenken opened this issue Feb 17, 2019 · 2 comments
Labels
good first issue Good for newcomers investigate Needs investigation

Comments

@dlangerenken
Copy link

The TypeScript project has announced that they're shifting focus to eslint from tslint

Is there any chance you can look into switching to eslint as well? I think this plugin would be very beneficial! I don't like to switch to typescript-eslint before I found an override-implementation.

@mzyil
Copy link
Contributor

mzyil commented Feb 19, 2019

I created this issue in the said project: typescript-eslint/typescript-eslint#293

This rule was supposed to come out of the box, but nobody wanted to do it. Thanks to @hmil , he took the matter into his own hands and solved for us. It would be better if the new project adopted this in their own project early on.

@hmil hmil added good first issue Good for newcomers investigate Needs investigation labels Feb 20, 2019
@hmil
Copy link
Owner

hmil commented Feb 20, 2019

Thanks for bringing this up. I guess someone needs to investigate what it would take to port this plugin to eslint. Maybe eslint exposes the same interface to the type system and then most stuff can be reused. Or they expose something completely different and then it's better to write a new plugin from scratch.
It could be useful to keep both plugins in the same repo though such that design discussions about the override keyword itself can be focused in the same place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers investigate Needs investigation
Projects
None yet
Development

No branches or pull requests

3 participants