Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable TileService elements in Manifest until the user enables them for use #4401

Open
fabikw opened this issue May 13, 2024 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@fabikw
Copy link

fabikw commented May 13, 2024

Home Assistant Android app version(s):
2024.4.1-full
Android version(s):
14 (AP1A.240405.002.B1)
Device model(s):
Google Pixel 7 Pro
Home Assistant version:
N/A
Last working Home Assistant release (if known):
N/A
Description of problem, include YAML if issue is related to notifications:
The first 12 TileServices declared in the manifest in https://github.com/home-assistant/android/blob/master/app/src/main/AndroidManifest.xml#L437 are enabled. This causes them to be visible in the tiles that can be added in Edit Mode for Quick Settings (and it takes a lot of space). Could the components instead be enabled programatically as they are needed (when the user sets them up)? Looking at

fun updateActiveTileServices(highestInUse: Int, context: Context) {
it seems that this is the goal, but instead of only 4 more enabled, there are 12 enabled by default.

Companion App Logs:


Screenshot or video of problem:

Additional information:

@fabikw fabikw added the bug Something isn't working label May 13, 2024
@dshokouhi
Copy link
Member

dshokouhi commented May 13, 2024

this was by design, so this is a enhancement and not a bug. We started out with 12 tiles originally and they were always enabled.

@dshokouhi dshokouhi added enhancement New feature or request and removed bug Something isn't working labels May 13, 2024
@jpelgrom
Copy link
Member

jpelgrom commented May 14, 2024

it seems that this is the goal, but instead of only 4 more enabled, there are 12 enabled by default.

To add to what @dshokouhi said as the person who implemented this: the goal is highest number used + 4 more with a minimum of 12 :) Because it was the default but also to prevent breaking changes / make it obvious that there are more than a few tiles.

@fabikw
Copy link
Author

fabikw commented May 16, 2024

Could we have a way of disabling the components for tiles that are not set up? Having 12 extra tiles there is a lot.

@dshokouhi
Copy link
Member

the tasker app AutoNotifications has 40 actually, every app is going to be different. This is not a screen that is always visible to the user either. You go in there add your tile and move on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants