Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert siri requests for target heating cooling state auto to a valid mode #60220

Merged
merged 2 commits into from Jan 12, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 23, 2021

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

- Siri will request an invalid thermostat mode (auto) when
  the device does not support it. Allow the value to be
  converted to a mode the device supports

- Requires ikalchev/HAP-python#392

- Fixes home-assistant#60203
@bdraco bdraco added waiting-for-upstream We're waiting for a change upstream and removed by-code-owner labels Nov 23, 2021
@project-bot project-bot bot added this to Needs review in Dev Nov 23, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 23, 2021
@bdraco bdraco changed the title Convert siri requests for auto to a valid mode Convert siri requests for target heating cooling state auto to a valid mode Nov 23, 2021
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 23, 2021
@bdraco
Copy link
Member Author

bdraco commented Dec 23, 2021

Not stale

@github-actions github-actions bot removed the stale label Dec 23, 2021
@bdraco bdraco removed the waiting-for-upstream We're waiting for a change upstream label Jan 11, 2022
@bdraco bdraco added this to the 2021.12.10 milestone Jan 11, 2022
@bdraco bdraco marked this pull request as ready for review January 11, 2022 23:22
@bdraco bdraco mentioned this pull request Jan 12, 2022
22 tasks
Dev automation moved this from By Code Owner to Reviewer approved Jan 12, 2022
@balloob balloob merged commit d3f980d into home-assistant:dev Jan 12, 2022
Dev automation moved this from Reviewer approved to Done Jan 12, 2022
@bdraco
Copy link
Member Author

bdraco commented Jan 12, 2022

Thanks 馃檹

@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Siri requests target heating cooling state of auto even when its not a valid value
3 participants