Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

dlna_dmr: Allow for upnp attributes with None contents #63892

Merged
merged 1 commit into from Jan 11, 2022

Conversation

chishm
Copy link
Contributor

@chishm chishm commented Jan 11, 2022

Proposed change

When getting device manufacturer or modelName from SSDP discovery info, treat all falsey values as an empty string. This is a minor bug fix for an edge case in some weird DLNA-DMR devices.

This bug fix can be safely cherry-picked to the current release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @StevenLooman, mind taking a look at this pull request as it has been labeled with an integration (dlna_dmr) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 11, 2022
@frenck frenck added this to the 2021.12.10 milestone Jan 11, 2022
Dev automation moved this from By Code Owner to Reviewer approved Jan 11, 2022
@frenck
Copy link
Member

frenck commented Jan 11, 2022

Thanks, @chishm 馃憤

@frenck frenck merged commit dc71d59 into home-assistant:dev Jan 11, 2022
Dev automation moved this from Reviewer approved to Done Jan 11, 2022
@chishm chishm deleted the dlna_dmr-fix-upnp-nonetype branch January 11, 2022 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Source: components/dlna_dmr/config_flow.py:477 AttributeError: 'NoneType' object has no attribute 'lower'
5 participants