New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert disabled_by to DeviceEntryDisabler on load #63944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes string comparisons introduced by "Make device entry disabled by an enum (home-assistant#60239)."
probot-home-assistant
bot
added
bugfix
core
has-tests
integration: deconz
integration: picnic
small-pr
PRs with less than 30 lines.
labels
Jan 11, 2022
Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @corneyl, mind taking a look at this pull request as it has been labeled with an integration ( |
frenck
reviewed
Jan 11, 2022
agners
changed the title
Fix string comparisons
Convert disabled_by to DeviceEntryDisabler on load
Jan 12, 2022
balloob
approved these changes
Jan 12, 2022
Nice catch! Thanks all! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
cherry-picked
cla-signed
core
has-tests
integration: deconz
integration: picnic
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Fix string comparison for newly introduced StrEnum.String comparison should be done using==
or!=
.is
/is not
compares addresses of object. It works sometimes due to string de-duplication, but its not a proper comparison for strings.Convert disabled_by to DeviceEntryDisabler on load.
Found the problem while debugging issue #63800.
This addresses all instances I found in #60239 and #58646.cc @scop @Adminiuga
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: