Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix august lock/unlock with older bridges #64143

Merged
merged 1 commit into from Jan 14, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 14, 2022

Proposed change

  • The bridges for the 2013 (v1)/2015 (v2) models would report success but never unlock

Changelog: bdraco/yalexs@v1.1.18...v1.1.19

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

- These bridges would report success but never unlock
@bdraco bdraco added this to the 2021.12.10 milestone Jan 14, 2022
@probot-home-assistant probot-home-assistant bot added integration: august small-pr PRs with less than 30 lines. labels Jan 14, 2022
@balloob balloob merged commit 2d5fe93 into home-assistant:dev Jan 14, 2022
bdraco added a commit to bdraco/home-assistant that referenced this pull request Jan 15, 2022
- This is the same fix as home-assistant#64143 but for code that is not
  present in 2021.12 so its split since this one should
  not be backported
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

August Lock integration broken in Home Assistant 2021.12.9
3 participants