Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure status is correct at start for older august bridges #64144

Merged
merged 1 commit into from Jan 15, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 14, 2022

Proposed change

but for code that is not present in 2021.12 so its split since this one should not be backported
Since we ended up backporting #64027 we should do this one as well

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

- This is the same fix as home-assistant#64143 but for code that is not
  present in 2021.12 so its split since this one should
  not be backported
@bdraco bdraco force-pushed the august_status_older_bridges branch from 9f3ffda to c173d4e Compare January 15, 2022 00:26
@bdraco bdraco marked this pull request as ready for review January 15, 2022 00:27
Dev automation moved this from Incoming to Reviewer approved Jan 15, 2022
@bdraco
Copy link
Member Author

bdraco commented Jan 15, 2022

Thanks 馃憤

@bdraco bdraco merged commit d183174 into home-assistant:dev Jan 15, 2022
Dev automation moved this from Reviewer approved to Done Jan 15, 2022
@bdraco bdraco deleted the august_status_older_bridges branch January 15, 2022 07:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2022
@bdraco bdraco added this to the 2021.12.10 milestone Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants