Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KNX onboarding when there is no yaml config defined yet #64216

Merged
merged 2 commits into from Jan 17, 2022

Conversation

farmio
Copy link
Contributor

@farmio farmio commented Jan 16, 2022

Proposed change

Fix KNX onboarding when there is no yaml config defined yet.

Previously the integration setup would just fail after finishing config_flow when there is no knx: key in configuration.yaml yet. This caused some confusion.
Now a warning is logged and the integration is useable (eg. services like knx.send).
We can't really distinguish between no yaml config and a reload at this point.

There are also some code movements in config_flow.py in this PR which I thought are really not worth a separate PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@balloob
Copy link
Member

balloob commented Jan 17, 2022

Should this go into a hot fix?

@balloob balloob merged commit 456d403 into home-assistant:dev Jan 17, 2022
@farmio farmio added this to the 2021.12.10 milestone Jan 17, 2022
@balloob balloob mentioned this pull request Jan 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants