Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphaned MAC addresses breaks UniFi options flow #64327

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jan 17, 2022

Breaking change

Proposed change

Multi selects expect all defaults to exist in the value list.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Jan 17, 2022

Same fix as #60061

@bdraco bdraco mentioned this pull request Jan 17, 2022
@Kane610 Kane610 merged commit d4e5094 into home-assistant:dev Jan 17, 2022
@Kane610 Kane610 deleted the unifi-filter_multi_select_defaults_to_always_exist branch January 17, 2022 21:37
@Kane610
Copy link
Member Author

Kane610 commented Jan 17, 2022

Thanks @bdraco should we add some error to the multi select if there is an object mismatch?

@bdraco
Copy link
Member

bdraco commented Jan 17, 2022

Thanks @bdraco should we add some error to the multi select if there is an object mismatch?

I'm pretty sure the error is happening on the frontend side since it used to not care before a frontend bump.

It would be good to improve the error message there as its hard to track down and confusing.

@Kane610
Copy link
Member Author

Kane610 commented Jan 17, 2022

@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants