Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): hass-cli raw ws for websocket apis #274

Merged
merged 2 commits into from Aug 30, 2019

Conversation

maxandersen
Copy link
Contributor

Why:

  • testing out websocket apis before there are commands for it
    are tedious. would be nice to have ability like raw get to
    access websocket api.

This change addreses the need by:

  • introduce hass-cli raw ws <method> --json <optional data> command.
    Example:
    hass-cli raw ws config/area_registry/delete --json='{ "area_id":"2c8bf93c8082492f99c989896962f207" }'
    

Resolves:

homeassistant_cli/plugins/raw.py Outdated Show resolved Hide resolved
homeassistant_cli/plugins/raw.py Outdated Show resolved Hide resolved
homeassistant_cli/plugins/raw.py Outdated Show resolved Hide resolved
homeassistant_cli/autocompletion.py Show resolved Hide resolved
homeassistant_cli/plugins/raw.py Outdated Show resolved Hide resolved
homeassistant_cli/autocompletion.py Show resolved Hide resolved
homeassistant_cli/autocompletion.py Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #274 into dev will increase coverage by 0.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #274      +/-   ##
==========================================
+ Coverage   74.91%   75.27%   +0.35%     
==========================================
  Files          22       22              
  Lines        1539     1561      +22     
==========================================
+ Hits         1153     1175      +22     
  Misses        386      386
Impacted Files Coverage Δ
homeassistant_cli/autocompletion.py 75.72% <100%> (+2.32%) ⬆️
homeassistant_cli/yaml.py 95.23% <100%> (ø) ⬆️
homeassistant_cli/plugins/raw.py 90.19% <100%> (+3.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a23de5...756e18c. Read the comment docs.

Why:

 * HomeAssistant dropped python 3.5, no need for us to sustain more pain.

This change addreses the need by:

 * Remove all references to python 3.5 in travis, circle and setup.*
   files.
Why:

 * testing out websocket apis before there are commands for it
   are tedious. would be nice to have ability like `raw get` to
   access websocket api.

This change addreses the need by:

 * introduce `hass-cli raw ws <method> --json <optional data>` command.
   Example:
   ```
   hass-cli raw ws config/area_registry/delete --json='{ "area_id":"2c8bf93c8082492f99c989896962f207" }'
   ```

 * Fixed a few mypy / static check errors.

Resolves home-assistant-ecosystem#271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants