Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for examples regarding "--columns" to make examples work (at leas… #305

Merged
merged 1 commit into from Oct 20, 2019

Conversation

haakonstorm
Copy link
Contributor

Fix for examples regarding --columns to make examples work
(at least for --output table which I've been testing! )

@homeassistant
Copy link

Hi @haakonstorm,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@codecov-io
Copy link

codecov-io commented Sep 8, 2019

Codecov Report

Merging #305 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #305   +/-   ##
=======================================
  Coverage   75.25%   75.25%           
=======================================
  Files          22       22           
  Lines        1560     1560           
=======================================
  Hits         1174     1174           
  Misses        386      386
Impacted Files Coverage Δ
homeassistant_cli/cli.py 76.13% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa918dd...58fb680. Read the comment docs.

@maxandersen
Copy link
Contributor

maxandersen commented Oct 20, 2019

sorry for late response but the fix is only partially right.

Yes, entity_name should be entity_id but attributes.friendly_name is still what is there when using hass-cli state list, its only for hass-cli entity list its name.

@maxandersen maxandersen merged commit 58fb680 into home-assistant-ecosystem:dev Oct 20, 2019
@maxandersen
Copy link
Contributor

merged but with fix that make it still use friendly_name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants