Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar color follows wrong color variable #2752

Open
Nezz opened this issue Apr 30, 2024 · 5 comments · Fixed by #2757
Open

Status bar color follows wrong color variable #2752

Nezz opened this issue Apr 30, 2024 · 5 comments · Fixed by #2757

Comments

@Nezz
Copy link

Nezz commented Apr 30, 2024

iOS device model, version and app version

Model Name: iPhone 15 Pro
Software Version: iOS 17.4.1
App version: 2024.624

Home Assistant Core Version
2024.4.4, 2024.5.0-b4

Describe the bug
The color of the status bar follows the --app-header-background-color variable. This is inconsistent with the browser where it follows --app-theme-color. It'd be nice to use that variable if it's set.

To Reproduce
Create a theme which sets app-theme-color:

app-theme-color: "#88827B" # Average header color, used on the top of the browser

Expected behavior
--app-theme-color should be used if it's set. The header color could still be used as a fallback.

Screenshots

Additional context
The frontend sets the theme color here:
https://github.com/home-assistant/frontend/blob/7120ad99b9bdd3d6dc648deb6ae5285d986f8744/src/state/themes-mixin.ts#L134

In the default theme the value of --app-header-background-color and --app-theme-color is the same.

@bgoncal
Copy link
Member

bgoncal commented May 8, 2024

I had to revert the PR, the app theme color doesn't always match the navigation bar, which makes it look weird in some situations like dark mode using the default themes

@Nezz
Copy link
Author

Nezz commented May 8, 2024

@bgoncal I think that should be fixed by this:
home-assistant/frontend#20671

@Nezz
Copy link
Author

Nezz commented May 8, 2024

Looks like the fix doesn't work. I'll try to get it patched up.

@bgoncal
Copy link
Member

bgoncal commented May 8, 2024

Looks like the fix doesn't work. I'll try to get it patched up.

Let's wait a bit until this ir tested in the frontend and we are sure it will behave as expected, but I will keep this on the radar, feel free to drop a message in a week or two

@bgoncal bgoncal reopened this May 8, 2024
@Nezz
Copy link
Author

Nezz commented May 8, 2024

Sounds good. I opened the fix:
home-assistant/frontend#20758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants