Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 17 - grouped switches in single tile without names #800

Open
maisun opened this issue Sep 19, 2023 · 17 comments
Open

iOS 17 - grouped switches in single tile without names #800

maisun opened this issue Sep 19, 2023 · 17 comments
Labels
question Further information is requested

Comments

@maisun
Copy link

maisun commented Sep 19, 2023

Hi,
Would like to report an issue after upgrading to iOS 17, just to be clear it is not something to do with the add-on but would like to bring some discussion on potential workaround.
After upgrading to iOS 17 the grouped items in single tile lose name description, it is particularly an issue if you have switches for many rooms and would like to start cleaning only certain rooms. Now those switches don't have a name/description in iOS 17.
In earlier version there was the workaround to rename the accessory but this workaround doesn't work in iOS 17 looks like.
I think as potential workaround maybe the add-on can allow user to define a list of rooms with one switch with the attempt to reduce the number of switches. Any thoughts or please share if you have another workaround? Many thanks!

@afharo
Copy link
Member

afharo commented Sep 19, 2023

I think as potential workaround maybe the add-on can allow user to define a list of rooms with one switch with the attempt to reduce the number of switches.

Just to make sure I understood:

  • Do you mean exposing a switch that would trigger the cleaning of a few rooms?
  • Or are you suggesting a selector (like the image below) where you have an ON/OFF button and a selector of which room to clean?
    image

@afharo afharo added the question Further information is requested label Sep 19, 2023
@maisun
Copy link
Author

maisun commented Sep 19, 2023

I think as potential workaround maybe the add-on can allow user to define a list of rooms with one switch with the attempt to reduce the number of switches.

Just to make sure I understood:

  • Do you mean exposing a switch that would trigger the cleaning of a few rooms?
  • Or are you suggesting a selector (like the image below) where you have an ON/OFF button and a selector of which room to clean?
    image

Sorry didn't make myself clear, I mean just allow to define "zones" with a list of room ids to reduce the number of switches, and then maybe we can set switches as lamp with different icon to differentiate them. It's not ideal solution but can potentially work out the limitation.

@maisun
Copy link
Author

maisun commented Sep 19, 2023

BTW the TV accessory sounds interesting however you cannot control the power as a fan.
One solution could be to use TV remote and volume control for fan speed, and in the remote it also has up, down, left, right button for remote control the cleaner, that could be fun idea :)

@afharo
Copy link
Member

afharo commented Nov 15, 2023

I'm wondering: if we find a way to "independent" accessories so that we can place each room's button in their own room, would it solve this issue?

@maisun
Copy link
Author

maisun commented Nov 15, 2023

I'm wondering: if we find a way to "independent" accessories so that we can place each room's button in their own room, would it solve this issue?

We can already do that now I think (to some extend). In my use-case I usually clean multiple rooms and hence less convenient to find the rooms and turn on the clean switch (I have hundreds of HK accessories).
Another option is to simply create a room for the cleaner so all switches are in the same place (I'm using this workaround now).

@T-Bone90
Copy link

I have the same problem with iOS 17.
Is there any fix for this?
IMG_3877

@maisun
Copy link
Author

maisun commented Dec 18, 2023

Think it's a change by Apple don't think there is a fix unfortunately

@tasict
Copy link

tasict commented Mar 6, 2024

@afharo @maisun
After iOS 16, the display in this area has been adjusted, and it is required to set the switch names to be displayed in the following manner.

addOptionalCharacteristic(this.platform.Characteristic.ConfiguredName);
setCharacteristic(this.platform.Characteristic.ConfiguredName, buttonNanoName);

If needed, I can submit a pull request to assist with the modification.

@maisun
Copy link
Author

maisun commented Mar 6, 2024

@afharo @maisun After iOS 16, the display in this area has been adjusted, and it is required to set the switch names to be displayed in the following manner.

addOptionalCharacteristic(this.platform.Characteristic.ConfiguredName);
setCharacteristic(this.platform.Characteristic.ConfiguredName, buttonNanoName);

If needed, I can submit a pull request to assist with the modification.

Yes please, it’s not very usable without name, very much appreciated!

@tasict
Copy link

tasict commented Mar 6, 2024

@afharo @maisun After iOS 16, the display in this area has been adjusted, and it is required to set the switch names to be displayed in the following manner.

addOptionalCharacteristic(this.platform.Characteristic.ConfiguredName);
setCharacteristic(this.platform.Characteristic.ConfiguredName, buttonNanoName);

If needed, I can submit a pull request to assist with the modification.

Yes please, it’s not very usable without name, very much appreciated!

Done
#889

@maisun
Copy link
Author

maisun commented Mar 6, 2024

@afharo @maisun After iOS 16, the display in this area has been adjusted, and it is required to set the switch names to be displayed in the following manner.

addOptionalCharacteristic(this.platform.Characteristic.ConfiguredName);
setCharacteristic(this.platform.Characteristic.ConfiguredName, buttonNanoName);

If needed, I can submit a pull request to assist with the modification.

Yes please, it’s not very usable without name, very much appreciated!

Done #889

Thank you! I just gave a try but got the below error, not sure what caused it.
[3/6/2024, 1:26:12 PM] Loaded 0 cached accessories from cachedAccessories.0EBD4D23CE69.
TypeError: Cannot read properties of undefined (reading 'platform')
at ensureName (/homebridge/node_modules/homebridge-xiaomi-roborock-vacuum/src/utils/ensure_name.ts:18:2)
at RoomsService.createRoom (/homebridge/node_modules/homebridge-xiaomi-roborock-vacuum/src/services/rooms_service.ts:88:15)
at new RoomsService (/homebridge/node_modules/homebridge-xiaomi-roborock-vacuum/src/services/rooms_service.ts:35:14)
at XiaomiRoborockVacuum.initializeServices (/homebridge/node_modules/homebridge-xiaomi-roborock-vacuum/src/xiaomi_roborock_vacuum_accessory.ts:94:19)
at new XiaomiRoborockVacuum (/homebridge/node_modules/homebridge-xiaomi-roborock-vacuum/src/xiaomi_roborock_vacuum_accessory.ts:80:32)
at ChildBridgeFork.startBridge (/homebridge/node_modules/homebridge/src/childBridgeFork.ts:172:52)

What I did is to add the below line to the ensure_name.ts:
service.setCharacteristic(this.platform.Characteristic.Name, name);

@tasict
Copy link

tasict commented Mar 6, 2024

I’ll fixed it later.

tasict added a commit to tasict/homebridge-xiaomi-roborock-vacuum that referenced this issue Mar 7, 2024
@afharo
Copy link
Member

afharo commented Mar 7, 2024

@afharo @maisun

After iOS 16, the display in this area has been adjusted, and it is required to set the switch names to be displayed in the following manner.



addOptionalCharacteristic(this.platform.Characteristic.ConfiguredName);

setCharacteristic(this.platform.Characteristic.ConfiguredName, buttonNanoName);



If needed, I can submit a pull request to assist with the modification.

@tasict, AFAIK, those changes were introduced in 0.31.1.
Did I misunderstand your proposal?

@tasict
Copy link

tasict commented Mar 8, 2024

@afharo In fact, upon closer review of your code, I found that there isn't much difference in logic between my code and yours. However, surprisingly, the plugin I wrote does not experience any text disappearance issues on the Home App.

https://github.com/tasict/homebridge-panasonic-smart-app/blob/ed1c3cd122a51f58b58e53e8ad1ad2625bb091b6/src/accessories/dehumidifier.ts#L178

IMG_6032

@maisun
Copy link
Author

maisun commented Mar 8, 2024

@afharo In fact, upon closer review of your code, I found that there isn't much difference in logic between my code and yours. However, surprisingly, the plugin I wrote does not experience any text disappearance issues on the Home App.

https://github.com/tasict/homebridge-panasonic-smart-app/blob/ed1c3cd122a51f58b58e53e8ad1ad2625bb091b6/src/accessories/dehumidifier.ts#L178

IMG_6032

Hi, are you on iOS 17? I started to have this problem with iOS 17, it worked fine with iOS 16 before upgrade.

@tasict
Copy link

tasict commented Mar 8, 2024

@maisun Yes, it's iOS 17.4

@afharo
Copy link
Member

afharo commented Mar 8, 2024

@tasict, maybe the difference is that this plugin only calls the setter if a custom name is specified.

I'll try to change that logic to always call it on init

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants