Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No prebuilt binaries found (target=4.2.7 runtime=node arch=x64 libc= platform=win32) #7

Closed
UziTech opened this issue Aug 13, 2019 · 4 comments

Comments

@UziTech
Copy link

UziTech commented Aug 13, 2019

Environment details

  • OS: Windows 10
  • OS version: x64
  • node-pty version: 0.9.0-beta21.legacy

Issue description

Trying to use platformio-ide-terminal on Atom v1.41.0-beta0

No prebuilt binaries found (target=4.2.7 runtime=node arch=x64 libc= platform=win32)

related platformio/platformio-atom-ide-terminal#766

@the-j0k3r
Copy link

the-j0k3r commented Aug 14, 2019

I can confirm from two independent sources that macOS and Linux and flavours work fine with electron 4.2.7, its just Windows binaries that seem to be affected with this issue.
I need to test locally other tags to see if I can narrow this down.

I know this is very likely unrelated but I have submitted a PR to fix the Windows builds completion. Ive no idea if that has any bearing on issue, likely not since electron 3.x builds works in all 3 macOS/Windows/Linux

edit
I also have compiled specifically to electron 4.2.0(<-build log @travis-ci) code change https://github.com/the-j0k3r/node-pty-prebuilt-multiarch/commit/39d54aecd1da22efa7045ac328e7856466c34cf4 this is not part of the node-abi but compiles**, if it works IDK.** didnt dump the compiled binaries to test.

@the-j0k3r
Copy link

ping

@the-j0k3r
Copy link

the-j0k3r commented Aug 17, 2019

@UziTech see atom/atom#19780 the cause of all the trouble,

@the-j0k3r
Copy link

I think its safe to close this issue.

@UziTech UziTech closed this as completed Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants