Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint oddities #90

Open
MikeGoldsmith opened this issue Nov 10, 2022 · 0 comments
Open

Endpoint oddities #90

MikeGoldsmith opened this issue Nov 10, 2022 · 0 comments
Labels
type: enhancement New feature or request
Milestone

Comments

@MikeGoldsmith
Copy link
Contributor

    Confirmed setting `HONEYCOMB_API_ENDPOINT` it appends the traces path, and setting `HONEYCOMB_TRACES_ENDPOINT` in another scenario it did not append the traces path or impact `endpoint` or `metricsEndpoint` (馃憤  matches our spec). Love the tests.

Couple oddities that I think could be addressed in a follow-up issue:

It may be a confusing for a user debugging to see the endpoint being different from tracesEndpoint - tracesEndpoint is what gets chosen over endpoint, and we don't overwrite endpoint value (don't think we should, but is it obvious to an end user which will "win" here?)

  "endpoint": "https://api.honeycomb.io",
  "tracesEndpoint": "http://collector:4318",
  "metricsEndpoint": "https://api.honeycomb.io/v1/metrics",

Another funky thing... When doing the maybeAppendPath for traces and metrics, we check for the existence of v1/traces and v1/metrics for each respectively. If someone sets the generic endpoint and includes v1/traces, their metricsEndpoint is then messed up. Maybe that's okay if we're assuming they only care about traces?

  "endpoint": "https://api.honeycomb.io/v1/traces",
  "tracesEndpoint": "https://api.honeycomb.io/v1/traces",
  "metricsEndpoint": "https://api.honeycomb.io/v1/traces/v1/metrics",

Originally posted by @JamieDanielson in #88 (review)

@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Nov 10, 2022
@MikeGoldsmith MikeGoldsmith added this to the GA milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant