WebSocket Helper not working

[mathysth]

What version of Hono are you using?

4.1.1

What runtime/platform is your app running on?

Bun

What steps can reproduce the bug?

I'm using Hono websocket helper but it return me and error when I try to connect to it

I cheked if my setup was good and for me it was

Here how I setup the ws to hono

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

No response

[nakasyou]

Hi @mathysth
Could you show me that unhidden fetch function in 2nd screenshot?
I think that problem is in it.

[mathysth]

Hey @nakasyou here the full code that you ask

boostrapApp().then((httpConfig) => {
  const logger = IocContainer.container.get(LoggerService);
  const controllerRoot = IocContainer.container.get(ControllerRoot);
  const socket = IocContainer.container.get(SocketProvider);
  try {
    serve({
      async fetch(req, server) {
        const serverConfig = await httpConfig?.fetch(req, { ip: server.requestIP(req) });
        return serverConfig;
      },
      websocket,
      port: httpConfig?.port,
    });
    // Initialize the socket
    socket.initSocket();

    // Setup all controllers
    controllerRoot.setup();
    logger.pino.info(`Hono 🥟 Server Listening on port ${httpConfig?.port}`);
  } catch (e) {
    logger.pino.error(`An error occurred during server initialization, ${e}`);
  }
});

[mathysth]

@nakasyou I found the problem but I'm still searching for the anwser.
according to hono doc you can retrieve user ip like the following :

const app = new Hono()

serve({
  fetch: (req, server) => {
    return app.fetch(req, { ip: server.requestIP(req) })
  },
  websocket,
  port: 3008,
});

But when you bind the ip as an env I think the server is not initialize... and then the websocket logic doesn't work anymore.
If I remove { ip: server.requestIP(req) } it's working for me

[nakasyou]

@mathysth, this may also be a problem with Hono.

As a workaround, you can use that:

await httpConfig?.fetch(req, { upgrade: server.upgrade })

or

await httpConfig?.fetch(req, server)

[mathysth]

@nakasyou I did this workaround, it's working, hope hono could fix this somedays. Thanks again
Also maybe this section need some edit

serve({
      async fetch(req, server) {
        const untypedServer = server as unknown as any
        untypedServer.ip = server.requestIP(req)
        const serverConfig = await httpConfig?.fetch(req, untypedServer);
        return serverConfig;
      },
      websocket,
      port: httpConfig?.port,
    });