Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct HOPR token base unit naming #5651

Open
NumberFour8 opened this issue Oct 23, 2023 · 5 comments · May be fixed by #5712
Open

Correct HOPR token base unit naming #5651

NumberFour8 opened this issue Oct 23, 2023 · 5 comments · May be fixed by #5712
Assignees
Labels
bug Something isn't working stale status:icebox

Comments

@NumberFour8
Copy link
Contributor

NumberFour8 commented Oct 23, 2023

Expected Behavior

1 HOPR = 1e18 weiHOPR
1 xDai = 1e18 wei

Current Behavior

Currently, when 1 HOPR is given in the configuration yaml file or CLI,
it is parsed a 1e-18 HOPR (ie. 1 weiHOPR).

Follow-up

  • provide updated configuration values
@NumberFour8 NumberFour8 added bug Something isn't working new issue A reviewer has to check this issue and apply all necessary labels and removed new issue A reviewer has to check this issue and apply all necessary labels labels Oct 23, 2023
@ausias-armesto ausias-armesto added this to the 2.0.0-rc.11 milestone Oct 23, 2023
@tolbrino tolbrino modified the milestones: 2.0.0-rc.11, 2.1.0-rc.1 Oct 24, 2023
@Teebor-Choka
Copy link
Contributor

@tolbrino @NumberFour8 Does this still apply after the #5623 was merged? I fixed the config parsing to take the value not as a digit, but a string containing the unit 1 HOPR which should then be correctly parsed by the Balance.

@NumberFour8
Copy link
Contributor Author

@tolbrino @NumberFour8 Does this still apply after the #5623 was merged? I fixed the config parsing to take the value not as a digit, but a string containing the unit 1 HOPR which should then be correctly parsed by the Balance.

Yes the base unit is still incorrect.

@Teebor-Choka Teebor-Choka self-assigned this Nov 8, 2023
@github-actions github-actions bot added the stale label Jan 8, 2024
@hoprnet hoprnet deleted a comment from github-actions bot Jan 8, 2024
@github-actions github-actions bot removed the stale label Jan 9, 2024
@tolbrino tolbrino modified the milestones: 2.1.X - saint-louis roadmap, 3.0.X - kaunas roadmap Jan 16, 2024
@mjadach-iv
Copy link
Contributor

mjadach-iv commented Feb 7, 2024

The answer from the API should in my opinion give back the balance in wei without the name of the currency in the string. This is so far the web3 industry standard.
Right now it returns:
image
for version 2.1.0-rc.1+pr.6009

@Teebor-Choka
Copy link
Contributor

Teebor-Choka commented Feb 7, 2024

Units removed in 2.1.0. API pending proper introduction, they remain present in the config.

@tolbrino tolbrino removed this from the 3.0.X - kaunas roadmap milestone Mar 15, 2024
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale status:icebox
Projects
No open projects
Status: 📋 backlog
Development

Successfully merging a pull request may close this issue.

5 participants