Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvement on hopli #6143

Open
5 tasks
QYuQianchen opened this issue Mar 29, 2024 · 0 comments
Open
5 tasks

Further improvement on hopli #6143

QYuQianchen opened this issue Mar 29, 2024 · 0 comments

Comments

@QYuQianchen
Copy link
Contributor

QYuQianchen commented Mar 29, 2024

Hopli improvement PR #6023 had the following TODOs:

  • New feature: create a Multicall ERC777 recipient contract which accepts minted and transferred wxHOPR tokens while forwarding calldata to the Multicall and executing the data payload. This will effectively mitigate the above-mentioned security concern.
  • Should not do unwrap() at all, unless a previous is_ok() check is present.
  • prefix all hopli env vars with HOPLI_ to prevents mixing up environment variables with other tools.
  • It'd be ideal to have docs comments start with a capital letter. You can generate the docs with cargo doc --no-deps in the workspace root and browse through the generated content in the browser.
  • Make get_provider_with_signer a trait based impl signature instead

Originally posted by @QYuQianchen in #5884 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants