Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make REST API accept both PeerIDs and chain addresses #6147

Open
3 tasks
NumberFour8 opened this issue Apr 4, 2024 · 0 comments
Open
3 tasks

Make REST API accept both PeerIDs and chain addresses #6147

NumberFour8 opened this issue Apr 4, 2024 · 0 comments
Labels
epic An issue which tracks multiple issues status:icebox

Comments

@NumberFour8
Copy link
Contributor

NumberFour8 commented Apr 4, 2024

Description

There's been an ongoing discussion whether the API inputs should be unified to accept only peer IDs or chain addresses.
Going only with the former or latter means a backward incompatible change to the REST API.

The resolution is actually quite simple and even backwards compatible: since peer IDs and chain addresses have clearly distinct text representation, the API can accept both and do the conversion internally.

Relevant issues

Definition of DONE

  • channels APIs updated
  • tickets APIs updated
  • node APIs updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic An issue which tracks multiple issues status:icebox
Projects
None yet
Development

No branches or pull requests

2 participants