Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated CLI arguments #6161

Open
Tracked by #6158
NumberFour8 opened this issue Apr 8, 2024 · 0 comments
Open
Tracked by #6158

Remove deprecated CLI arguments #6161

NumberFour8 opened this issue Apr 8, 2024 · 0 comments

Comments

@NumberFour8
Copy link
Contributor

NumberFour8 commented Apr 8, 2024

Many CLI arguments are already deprecated and should be removed entirely in 3.0 release.

See e.g.:

// TODO: strategy configuration from the CLI should be removed in 3.0!
// strategy
if let Some(x) = cli_args.default_strategy.and_then(|s| Strategy::from_str(&s).ok()) {
// Clear all the default strategies and just use the given one
cfg.hopr.strategy.strategies = vec![x];
}
// Add auto-redeeming strategy if not already there
if cli_args.auto_redeem_tickets == 0
&& !cfg
.hopr
.strategy
.strategies
.iter()
.any(|s| matches!(s, AutoRedeeming(_)))
{
cfg.hopr.strategy.strategies.push(AutoRedeeming(Default::default()));
}

@Teebor-Choka Teebor-Choka changed the title Removed deprecated CLI arguments Remove deprecated CLI arguments May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant