Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new strategy: remove a channel to a node, if the node was not seen for X amount of time #6222

Open
mjadach-iv opened this issue Apr 30, 2024 · 1 comment
Labels
feature New feature or request status:new

Comments

@mjadach-iv
Copy link
Contributor

Is your feature related to a problem?

HOPRd is not closing channels to nodes that it doesn't see on the network and doesn't have in the local node database.

Describe the feature you'd like

The strategy would accept time like '5m', '24h', '30d'.
It should close channels if a node was not seen by our node in that specified time.

If a node is present on the node database, then we can use lastSeen for that information.
If the node database is removed or a node is not present in that db, then we should take into account node uptime as a counter since when the nodes on the network are offline.

@mjadach-iv mjadach-iv added feature New feature or request status:new labels Apr 30, 2024
@NumberFour8
Copy link
Contributor

If the node database is removed or a node is not present in that db, then we should take into account node uptime as a counter since when the nodes on the network are offline.

As mentioned in the meeting, this part would be ineffective for those that restart their node from time to time (e.g. due to updating).

The situation where a node is not in the DB is an edge-case IMHO, since it is the result of DB deletion in our staging environment.
For nodes that are in the DB, this is a non-issue, since such node already has some quality (which would be low if the last seen value is old), and the standard algorithm of Promiscuous strategy will apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request status:new
Projects
None yet
Development

No branches or pull requests

2 participants