Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non meaningful traces #6231

Open
7 tasks
ausias-armesto opened this issue May 6, 2024 · 1 comment
Open
7 tasks

Remove non meaningful traces #6231

ausias-armesto opened this issue May 6, 2024 · 1 comment
Labels
devops This issue or pull request addresses a change in "devops" feature New feature or request status:new toolchain Developer and product happiness

Comments

@ausias-armesto
Copy link
Contributor

ausias-armesto commented May 6, 2024

Is your feature related to a problem?

The current amount of traces make debugging really difficult. There are plenty of traces that can be removed from being sent to the Trace collector.

Describe the feature you'd like

  • Skip sending traces for ping requests
  • Skip sending traces for heartbeat
  • Skip sending traces for /api/v3/node/metrics
  • Skip sending traces for /healthyz
  • Rename trace for POST: /api/v3/messages
  • Rename trace for POST: /api/v3/messages/peek-all
  • Rename trace for POST: /api/v3/messages/pop-all

The goal is that reading traces from a load testing for phttp execution provide meaningful traces. So the proposed procedure would be:

  • Modify traces
  • Deploy phttp-staging with this PR docker tag
  • Execute phttp load testing
  • Explore Tempo traces and check that they show meaningful traces.
  • Improve traces(renaming or deletion) based on the execution.
@ausias-armesto ausias-armesto added feature New feature or request status:new devops This issue or pull request addresses a change in "devops" toolchain Developer and product happiness labels May 6, 2024
@Teebor-Choka
Copy link
Contributor

All HTTP framework traces stem from the same tracing middleware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops This issue or pull request addresses a change in "devops" feature New feature or request status:new toolchain Developer and product happiness
Projects
None yet
Development

No branches or pull requests

2 participants