Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc: Failing unit test in NodeSafeRegistryTest #6251

Open
tolbrino opened this issue May 10, 2024 · 0 comments
Open

sc: Failing unit test in NodeSafeRegistryTest #6251

tolbrino opened this issue May 10, 2024 · 0 comments
Assignees

Comments

@tolbrino
Copy link
Contributor

A test in NodeSafeRegistryTest fails.

Failing tests:
Encountered 1 failing test in test/node-stake/NodeSafeRegistry.t.sol:HoprNodeSafeRegistryTest
[FAIL. Reason: log != expected log; counterexample: calldata=0x41b81e3a00000000000000000000000148fb8a6d817e4747a875e96f1bcfe536ab2e951700000000000000000000000086404a9aaab5b0af3db29e4d206a3dbe40d023f1 args=[1878158518633413214242173370809153996302846956823 [1.878e48], 0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1]] testFuzz_RegisterSafeWithNodeSig(uint256,address) (runs: 160, μ: 119149, ~: 119017)
2024-05-10T12:45:48.9866760Z �[31m[FAIL. Reason: log != expected log; counterexample: calldata=0x41b81e3a00000000000000000000000148fb8a6d817e4747a875e96f1bcfe536ab2e951700000000000000000000000086404a9aaab5b0af3db29e4d206a3dbe40d023f1 args=[1878158518633413214242173370809153996302846956823 �[2;49;39m[1.878e48]�[0m, 0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1]]�[0m testFuzz_RegisterSafeWithNodeSig(uint256,address) (runs: 160, μ: 119149, ~: 119017)
2024-05-10T12:45:48.9870043Z Logs:
2024-05-10T12:45:48.9870656Z   Bound Result 413214242173370809153996302846956823
2024-05-10T12:45:48.9871203Z 
2024-05-10T12:45:48.9871417Z Traces:
2024-05-10T12:45:48.9872354Z   [871183] �[32mHoprNodeSafeRegistryTest�[0m::�[32msetUp�[0m()�[33m�[0m
2024-05-10T12:45:48.9873605Z     ├─ [0] �[34mVM�[0m::�[34maddr�[0m(<pk>)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9874826Z     │   └─ �[34m← �[0m�[34m[Return] �[0m0xE6b3367318C5e11a6eED3Cd0D850eC06A02E9b90
2024-05-10T12:45:48.9876299Z     ├─ [807895] �[33m→ �[0m�[33mnew�[0m MyNodeSafeRegistry@0xFEfC6BAF87cF3684058D62Da40Ff3A795946Ab06
2024-05-10T12:45:48.9878238Z     │   ├─ emit �[36mDomainSeparatorUpdated�[0m(domainSeparator: 0xa55feb618fbdebf36a3817cdd2bac71c1771d15da5cc3a7550b2b59aea02e1b3)
2024-05-10T12:45:48.9879831Z     │   └─ �[32m← �[0m�[32m[Return] �[0m3364 bytes of code
2024-05-10T12:45:48.9880724Z     └─ �[32m← �[0m�[32m[Stop] �[0m
2024-05-10T12:45:48.9881175Z 
2024-05-10T12:45:48.9882756Z   [85397] �[31mHoprNodeSafeRegistryTest�[0m::�[31mtestFuzz_RegisterSafeWithNodeSig�[0m(1878158518633413214242173370809153996302846956823 �[2;49;39m[1.878e48]�[0m, 0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1)�[33m�[0m
2024-05-10T12:45:48.9885187Z     ├─ [0] �[32mconsole�[0m::�[32mlog�[0m("Bound Result", 413214242173370809153996302846956823 �[2;49;39m[4.132e35]�[0m)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9886587Z     │   └─ �[32m← �[0m�[32m[Stop] �[0m
2024-05-10T12:45:48.9888073Z     ├─ [3096] �[32mPrecompileUtils�[0m::�[32misPrecompileAddress�[0m(0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1)�[33m [delegatecall]�[0m
2024-05-10T12:45:48.9889447Z     │   └─ �[32m← �[0m�[32m[Return] �[0mfalse
2024-05-10T12:45:48.9890442Z     ├─ [0] �[34mVM�[0m::�[34maddr�[0m(<pk>)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9891645Z     │   └─ �[34m← �[0m�[34m[Return] �[0m0x6B7f55F60B4c55eA1E8Ec52A07f17b3C4ca648DD
2024-05-10T12:45:48.9892823Z     ├─ [0] �[34mVM�[0m::�[34massume�[0m(true)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9893714Z     │   └─ �[34m← �[0m�[34m[Return] �[0m
2024-05-10T12:45:48.9894635Z     ├─ [0] �[34mVM�[0m::�[34maddr�[0m(<pk>)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9895753Z     │   └─ �[34m← �[0m�[34m[Return] �[0m0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1
2024-05-10T12:45:48.9897808Z     ├─ [2714] �[32mMyNodeSafeRegistry�[0m::�[32misNodeSafeRegistered�[0m(0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1, 0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9899511Z     │   └─ �[32m← �[0m�[32m[Return] �[0mfalse
2024-05-10T12:45:48.9900515Z     ├─ [0] �[34mVM�[0m::�[34massertFalse�[0m(false)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9901476Z     │   └─ �[34m← �[0m�[34m[Return] �[0m
2024-05-10T12:45:48.9902936Z     ├─ [632] �[32mMyNodeSafeRegistry�[0m::�[32mnodeSigNonce�[0m(0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9904249Z     │   └─ �[32m← �[0m�[32m[Return] �[0m0
2024-05-10T12:45:48.9905408Z     ├─ [284] �[32mMyNodeSafeRegistry�[0m::�[32mNODE_SAFE_TYPEHASH�[0m()�[33m [staticcall]�[0m
2024-05-10T12:45:48.9906922Z     │   └─ �[32m← �[0m�[32m[Return] �[0m0xa8ac7aed128d1a2da0773fecc80b6265d15f7e62bf4401eb23bd46c3fcf5d2f8
2024-05-10T12:45:48.9908428Z     ├─ [2383] �[32mMyNodeSafeRegistry�[0m::�[32mdomainSeparator�[0m()�[33m [staticcall]�[0m
2024-05-10T12:45:48.9910072Z     │   └─ �[32m← �[0m�[32m[Return] �[0m0xa55feb618fbdebf36a3817cdd2bac71c1771d15da5cc3a7550b2b59aea02e1b3
2024-05-10T12:45:48.9911380Z     ├─ [0] �[34mVM�[0m::�[34maddr�[0m(<pk>)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9912490Z     │   └─ �[34m← �[0m�[34m[Return] �[0m0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1
2024-05-10T12:45:48.9924521Z     ├─ [0] �[34mVM�[0m::�[34msign�[0m("<pk>", 0x90bf6d77d6d5e583ff9c624ac6c58be261426a3f520384b1cc19fc3aaf304519)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9926752Z     │   └─ �[34m← �[0m�[34m[Return] �[0m27, 0x884e7979c9d5f1f03c4566cfbb83a0c449fbd7a355cd081dd6f7d98fd0777e2a, 0x6bf5966003e4228ac98f06a623b08764a5053a391b5090593f8ce4d7a2ffa024
2024-05-10T12:45:48.9930124Z     ├─ [3000] �[32mPRECOMPILES�[0m::�[32mecrecover�[0m(0x90bf6d77d6d5e583ff9c624ac6c58be261426a3f520384b1cc19fc3aaf304519, 27, 61653199873094233703033552481160971385866020297442484881436542040585381838378, 48831390179796892489571857948973455682022196634373692702992711633435289952292)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9932740Z     │   └─ �[32m← �[0m�[32m[Return] �[0m0x00000000000000000000000086404a9aaab5b0af3db29e4d206a3dbe40d023f1
2024-05-10T12:45:48.9934026Z     ├─ [0] �[34mVM�[0m::�[34massertTrue�[0m(true)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9934938Z     │   └─ �[34m← �[0m�[34m[Return] �[0m
2024-05-10T12:45:48.9936495Z     ├─ [0] �[34mVM�[0m::�[34massertEq�[0m(0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1, 0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9937887Z     │   └─ �[34m← �[0m�[34m[Return] �[0m
2024-05-10T12:45:48.9939357Z     ├─ [3096] �[32mPrecompileUtils�[0m::�[32misPrecompileAddress�[0m(0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1)�[33m [delegatecall]�[0m
2024-05-10T12:45:48.9940737Z     │   └─ �[32m← �[0m�[32m[Return] �[0mfalse
2024-05-10T12:45:48.9941678Z     ├─ [0] �[34mVM�[0m::�[34maddr�[0m(<pk>)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9942786Z     │   └─ �[34m← �[0m�[34m[Return] �[0m0x6B7f55F60B4c55eA1E8Ec52A07f17b3C4ca648DD
2024-05-10T12:45:48.9944040Z     ├─ [0] �[34mVM�[0m::�[34massume�[0m(true)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9944940Z     │   └─ �[34m← �[0m�[34m[Return] �[0m
2024-05-10T12:45:48.9945872Z     ├─ [0] �[34mVM�[0m::�[34maddr�[0m(<pk>)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9946980Z     │   └─ �[34m← �[0m�[34m[Return] �[0m0x6B7f55F60B4c55eA1E8Ec52A07f17b3C4ca648DD
2024-05-10T12:45:48.9950859Z     ├─ [0] �[34mVM�[0m::�[34mmockCall�[0m(0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1, 0xcc2f845200000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000064, 0x0000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000010000000000000000000000006b7f55f60b4c55ea1e8ec52a07f17b3c4ca648dd)�[33m�[0m
2024-05-10T12:45:48.9953957Z     │   └─ �[34m← �[0m�[34m[Return] �[0m
2024-05-10T12:45:48.9955623Z     ├─ [0] �[34mVM�[0m::�[34mmockCall�[0m(0x6B7f55F60B4c55eA1E8Ec52A07f17b3C4ca648DD, 0x4a1ba408, 0x0000000000000000000000000000000000000000000000000000000000000001)�[33m�[0m
2024-05-10T12:45:48.9957083Z     │   └─ �[34m← �[0m�[34m[Return] �[0m
2024-05-10T12:45:48.9959155Z     ├─ [0] �[34mVM�[0m::�[34mmockCall�[0m(0x6B7f55F60B4c55eA1E8Ec52A07f17b3C4ca648DD, 0x0175015200000000000000000000000086404a9aaab5b0af3db29e4d206a3dbe40d023f1, 0x0000000000000000000000000000000000000000000000000000000000000001)�[33m�[0m
2024-05-10T12:45:48.9961052Z     │   └─ �[34m← �[0m�[34m[Return] �[0m
2024-05-10T12:45:48.9962534Z     ├─ [0] �[34mVM�[0m::�[34mexpectEmit�[0m(true, true, false, false, MyNodeSafeRegistry: [0xFEfC6BAF87cF3684058D62Da40Ff3A795946Ab06])�[33m�[0m
2024-05-10T12:45:48.9963879Z     │   └─ �[34m← �[0m�[34m[Return] �[0m
2024-05-10T12:45:48.9965459Z     ├─ emit �[36mRegisteredNodeSafe�[0m(safeAddress: 0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1, nodeAddress: 0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1)
2024-05-10T12:45:48.9969070Z     ├─ [35322] �[31mMyNodeSafeRegistry�[0m::�[31mregisterSafeWithNodeSig�[0m(0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1, 0x86404a9AaAb5B0af3Db29E4D206a3dBe40D023f1, 0x884e7979c9d5f1f03c4566cfbb83a0c449fbd7a355cd081dd6f7d98fd0777e2a6bf5966003e4228ac98f06a623b08764a5053a391b5090593f8ce4d7a2ffa0241b)�[33m�[0m
2024-05-10T12:45:48.9973452Z     │   ├─ [3000] �[32mPRECOMPILES�[0m::�[32mecrecover�[0m(0x90bf6d77d6d5e583ff9c624ac6c58be261426a3f520384b1cc19fc3aaf304519, 27, 61653199873094233703033552481160971385866020297442484881436542040585381838378, 48831390179796892489571857948973455682022196634373692702992711633435289952292)�[33m [staticcall]�[0m
2024-05-10T12:45:48.9976069Z     │   │   └─ �[32m← �[0m�[32m[Return] �[0m0x00000000000000000000000086404a9aaab5b0af3db29e4d206a3dbe40d023f1
2024-05-10T12:45:48.9977234Z     │   └─ �[31m← �[0m�[31m[Revert] �[0mNodeIsContract()
2024-05-10T12:45:48.9978136Z     └─ �[31m← �[0m�[31m[Revert] �[0mlog != expected log

GHA: https://github.com/hoprnet/hoprnet/actions/runs/9032404687/job/24820531225?pr=6250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants