Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'send' log only logs the original data you send and doesnt take into consideration possible 'encode' changes #30

Open
dagadbm opened this issue Dec 7, 2021 · 3 comments

Comments

@dagadbm
Copy link

dagadbm commented Dec 7, 2021

Since we can modify the sent data using the
encode/decode functions it would be nice if the logging logged what ends up actually being after the config.encode() function is being run

this.log('send', message_data)

@dagadbm
Copy link
Author

dagadbm commented Dec 7, 2021

Here is another way in which the send is also not really correct:

image

The message hasnt been sent yet because ws is null so it kind of leads to errors

@houd1ni
Copy link
Owner

houd1ni commented Dec 7, 2021

Originally, encode and decode were added because of large data chunks (not text!) were packed very specifically. Before the addition, it could lead to noticeable performance issues. It also even been a thought that it's too heavy load on a dev machine sometimes and might become partially hidden because of showing the messages every time.

@houd1ni
Copy link
Owner

houd1ni commented Feb 28, 2023

This will be updated after #37 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants