Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ed fusio parser] feed_infos.txt should be mandatory in ntfs v0.7 #2276

Open
datanel opened this issue Jan 2, 2018 · 4 comments
Open

[ed fusio parser] feed_infos.txt should be mandatory in ntfs v0.7 #2276

datanel opened this issue Jan 2, 2018 · 4 comments

Comments

@datanel
Copy link
Member

datanel commented Jan 2, 2018

related to #2275

feed_infos.txt should be mandatory in https://github.com/CanalTP/navitia/blob/dev/source/ed/connectors/fusio_parser.cpp#L1745

@eturck
Copy link
Contributor

eturck commented Jan 2, 2018

Sorry to interfere. We currently have a few ntfs export and we do not use feed_infos.txt (yet) since the documentation was stating that it's optional.
Why will it become mandatory? In the doc I only see 'ntfs_version' as a mandatory feed_info_param but it doesn't seem to be read in fusio_parser (maybe I missed it). All other feed_info_param seems optional. Will an empty feed_infos.txt would be valid then?

@pbougue
Copy link
Contributor

pbougue commented Jan 2, 2018

@eturck you've been right to interfere :)
So the plan is to make it mandatory in the next NTFS version to allow people to create (or modify) the parser depending on the NTFS version.
We will probably only support the reading of the last version, but if someone wanted to add support of previous ones, it would be possible. And if someone wants to support previous NTFS version, he would have to guess the version (0.6?) if feed_info is missing.

So if you're OK : NTFS 0.6 has optional feed_info (and a warning that it's gonna be mandatory)
NTFS 0.7 will have a mandatory feed info (to be merged whenever you're ready).

@datanel datanel changed the title [ed fusio parser] feed_infos.txt should be mandatory [ed fusio parser] feed_infos.txt should be mandatory in ntfs v0.7 Jan 2, 2018
@eturck
Copy link
Contributor

eturck commented Jan 2, 2018

Yes it's ok for me. It's pretty easy to modify for us anyway I was mainly just curious :).
NTFS v0.7 is coming soon? Any exciting changes or just feed_info 😃? Should we bother @prhod for months like we did 2 years ago to have the documentation on github 😁?

@pbougue
Copy link
Contributor

pbougue commented Jan 2, 2018

You can always bother @prhod !
But the only thing that's coming and a breaking change is that feed_info thing 😃
It's gonna be clearer and that problem is gonna be behind, that's just the point of it.
We may get an English doc at some point,but I don't want to over-promise 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants