Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set config.force_ssl=true #268

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Set config.force_ssl=true #268

merged 1 commit into from
Feb 8, 2022

Conversation

nick-bessin
Copy link
Contributor

@nick-bessin nick-bessin commented Feb 8, 2022

We've found this link where we've pointed out that one can force heroku to use the ssl certificate.
https://help.heroku.com/J2R1S4T8/can-heroku-force-an-application-to-use-ssl-tls

@NikkelM NikkelM added this to In progress in FNHP - Kanban Board via automation Feb 8, 2022
@NikkelM NikkelM linked an issue Feb 8, 2022 that may be closed by this pull request
@ldreessen ldreessen self-requested a review February 8, 2022 14:54
FNHP - Kanban Board automation moved this from In progress to Reviewer approved Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #268 (c526341) into main (8abaf50) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   77.84%   77.84%           
=======================================
  Files          52       52           
  Lines         984      984           
=======================================
  Hits          766      766           
  Misses        218      218           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8abaf50...c526341. Read the comment docs.

@nick-bessin nick-bessin merged commit 3bfcd14 into main Feb 8, 2022
@nick-bessin nick-bessin deleted the ssl_activation branch February 8, 2022 14:55
FNHP - Kanban Board automation moved this from Reviewer approved to Merged Feb 8, 2022
FranzSw pushed a commit that referenced this pull request Feb 8, 2022
Co-authored-by: NikkelM <nikkel.mollenhauer@student.hpi.de>
ldreessen pushed a commit that referenced this pull request Feb 8, 2022
Co-authored-by: NikkelM <nikkel.mollenhauer@student.hpi.de>

Co-authored-by: Nick Bessin <68278780+SinNeax@users.noreply.github.com>
Co-authored-by: NikkelM <nikkel.mollenhauer@student.hpi.de>
NikkelM added a commit that referenced this pull request Feb 17, 2022
* First working version

* Work done

* Closes #185

* Track all changes

* converting search results to geojson

Co-authored-by: Benjamin Frost <Benjamin-Frost@users.noreply.github.com>

* adds markers for search results

Co-authored-by: Benjamin Frost <Benjamin-Frost@users.noreply.github.com>

* added HPI geocoder

* added reverse geolocation

* doesnt show students for not logged in users as search results

* Map 19/navigation start (#188)

* implements navigation route, that takes two points and starts navigation.

* navigation route uses the current position as starting point

* adds test

* linting

* changed "context" in test

* refactor: auto format scss

* fix: detail and search page list height

* test: add to_string tests

* feat: add course search

* fix: add informations to people factory

* test: add and refactor search tests

* run cucumber tests workflow on push (#246)

* persist query

* use local storage

* empty

* fix test

* add test

* add option for hamburger menu

* add id

* Fix routing popup showing when room popup is opened

* First test for room popup

* refactors first test for room popup

* fix first test for room popup

* fix room tests

* fix room tests

* made case sensitive tests

* wip

* fix room tests

* wip

* case insensitve search (maybe) ^^

* wip

* case insensitive ?

* rubocop friendly

* refactoring, bugfixes and adding normal geocoding

* fit map bounds to markers

Co-authored-by: Laura Meister <dieknolle3333@users.noreply.github.com>

* fit map bounds to search result markers

* fix selection of one room

* Update features/scenarios/search/show_search_results.feature

Co-authored-by: Cedric Lorenz <37962195+cedric-lorenz@users.noreply.github.com>

* 111-related-matches (#247)

* Return related searchable records

* Sort more results

Make related results less prioritized

* Fix and refactor tests

* Add tests and fix sorting

* Use to_s instead of to_string

* Update app/controllers/search_controller.rb

Co-authored-by: elenagensch <68114173+elenagensch@users.noreply.github.com>

* Update app/controllers/search_controller.rb

Co-authored-by: elenagensch <68114173+elenagensch@users.noreply.github.com>

* Update app/controllers/search_controller.rb

Co-authored-by: elenagensch <68114173+elenagensch@users.noreply.github.com>

* Update app/controllers/search_controller.rb

Co-authored-by: elenagensch <68114173+elenagensch@users.noreply.github.com>

* Update features/scenarios/search/search_for_related.feature

Co-authored-by: elenagensch <68114173+elenagensch@users.noreply.github.com>

* Correct keyword in cucumber test

* Change comment in search controller

* Adjust comment again

* Linting issues

* Make tests green

* Refactor feature tests

* Format code and change .rubocop.yml

* Fix tests and tag priority sorting

* Update searchable_record.rb

* Fix tests from merge

Co-authored-by: sm1lla <smilla.fox@student.hpi.uni-potsdam.de>
Co-authored-by: Smilla Fox <51457307+sm1lla@users.noreply.github.com>
Co-authored-by: elenagensch <68114173+elenagensch@users.noreply.github.com>

* updates people model and changes prohibited keys to person view

* updates migration

* fix people show

* fix people search test

* update db

* debug deployment

* Redesign search page

* fix search tests

* removed token comment

* Center the search vertically

* inital webmanifest

* rename variable and switch from layergroup to layer

* correct indentation

* start implementing Ajax approach

* try to send remote call

* fix search index

* fix empty string bug

* add new feature

* add feature test for search result display

* format js

* Set force_ssl=true (#268) (#269)

Co-authored-by: NikkelM <nikkel.mollenhauer@student.hpi.de>

Co-authored-by: Nick Bessin <68278780+SinNeax@users.noreply.github.com>
Co-authored-by: NikkelM <nikkel.mollenhauer@student.hpi.de>

* fix missing import

* fix bottombar options redirect

* implement redirects in options page

* implement pure ajax and change to only html for form

* adopt search results partial to master state

* 211-update chair ui (#254)

* update chair ui

* implemented requested changes

* make placeholder chair image square

Co-authored-by: Margarete <margarete.dippel@student.hpi.de>

* create detail page for courses (#255)

Co-authored-by: Margarete <margarete.dippel@student.hpi.de>

* feat: added css for circular pictures

* poi ui without tests

* write tests for poi detail page

* refactor: rubocop corrections

* fix: variable assignment

* implement redirects in not signed in options page

* adds options page to navbar

* changes options icon in navbar

* add suggestion when there are no search results (#263)

* add suggestion when there are no search results

* do not show suggestions on first visit

* update lockfiles

* adopt new changes to search results on master

* fix tests and start to adopt for map search

* Closes 275

* fix: test poi name

* add live search on map

* add map marker refresh

* make similar results only dependent on more results

* fix: linting issues

* Switch search bar positon on focus

* fix: course picture

* Fix zoom on 'Show on map' click

* Fix popup not removing

* fix linter issues

* adopt search result structure of dev

* add error message and make nice

* Interface to select floor (#232)

*added title and red box

* multiple floor interfaces

* fix(map): no overlaping layers when no room selected

* Start working on search page

* added loading search page according to entered query

* Fix merge issues

* 200 navigation button (#265)

* add navigation route to button

* navigate to center of mass when clicking navigate button in detail view

* use other navigation button, fix tests

* delete puts and fix redeclaration of variable

* rename css class, fix failures on dev

* change icon of navigation button

* Removed force_ssl which was part of a fix for #249 but lead to the login not working anymore

* delete unnessary files

* fix indoor map being built before outdoor map

Co-authored-by: Marie Fischer <marie.fischer@student.hpi.uni-potsdam.de>
Co-authored-by: Judith <39854388+felix-20@users.noreply.github.com>
Co-authored-by: NikkelM <nikkel.mollenhauer@student.hpi.de>
Co-authored-by: Paul Sieben <67124476+PaulVII@users.noreply.github.com>

Co-authored-by: tfiedlerdev <tfiedlerdevelopment@gmail.com>
Co-authored-by: LeonHermann322 <Leon.Hermann@student.hpi.uni-potsdam.de>
Co-authored-by: Benjamin Frost <Benjamin-Frost@users.noreply.github.com>
Co-authored-by: Tobias Sträubig <tobi_2001@hotmail.de>
Co-authored-by: treyfel <58570309+treyfel@users.noreply.github.com>
Co-authored-by: rothaarlappen <37540536+rothaarlappen@users.noreply.github.com>
Co-authored-by: Lukas Wenner <lukas.wenner@web.de>
Co-authored-by: cdfhalle <82583544+cdfhalle@users.noreply.github.com>
Co-authored-by: elenagensch <68114173+elenagensch@users.noreply.github.com>
Co-authored-by: Benjamin Frost <bfrost.schule@gmail.com>
Co-authored-by: Tom Richter <tomrichter99@gmail.com>
Co-authored-by: MartinPreiss <martinpreiss524@gmail.com>
Co-authored-by: Leon Hermann <61618825+LeonHermann322@users.noreply.github.com>
Co-authored-by: DevSchmidtchen <contact@schmidtchen.me>
Co-authored-by: Laura Meister <dieknolle3333@users.noreply.github.com>
Co-authored-by: MartinPreiss <68462093+MartinPreiss@users.noreply.github.com>
Co-authored-by: Cedric Lorenz <37962195+cedric-lorenz@users.noreply.github.com>
Co-authored-by: Abdullatif Ghajar <62988232+AbdullatifGhajar@users.noreply.github.com>
Co-authored-by: sm1lla <smilla.fox@student.hpi.uni-potsdam.de>
Co-authored-by: Smilla Fox <51457307+sm1lla@users.noreply.github.com>
Co-authored-by: Kirill Postnov <kirill.postnov@student.hpi.uni-potsdam.de>
Co-authored-by: Tobias Sträubig <42702024+t-straeubig@users.noreply.github.com>
Co-authored-by: Paul Sieben <67124476+PaulVII@users.noreply.github.com>
Co-authored-by: Lucas Liebe <lucasliebe.ll@gmail.com>
Co-authored-by: Franz Sauerwald <15076254+FranzSw@users.noreply.github.com>
Co-authored-by: Nick Bessin <68278780+SinNeax@users.noreply.github.com>
Co-authored-by: lucasliebe <33379641+lucasliebe@users.noreply.github.com>
Co-authored-by: richardschiemenz <61618635+richardschiemenz@users.noreply.github.com>
Co-authored-by: Margarete <margarete.dippel@student.hpi.de>
Co-authored-by: cdfhalle <conradhalle@gmail.com>
Co-authored-by: Nikola Genchev <68203919+kolioOtSofia@users.noreply.github.com>
Co-authored-by: Kirill <kirill.postnov@gmx.de>
Co-authored-by: 23mafi <68427675+23mafi@users.noreply.github.com>
Co-authored-by: Marie Fischer <marie.fischer@student.hpi.uni-potsdam.de>
Co-authored-by: Judith <39854388+felix-20@users.noreply.github.com>
Co-authored-by: Margarete01 <57364741+Margarete01@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Fix the current location error on iOS
3 participants