fix(htmlhint.ts): replace deprecated request module with what-wg fetch (#670)

* fix(htmlhint.ts): replace deprecated request module
Replace deprecated request module with what-wg fetch.

* fix(bin/htmlhint): Add execute permission.

* chore(package.json): add node-fetch 2.x types

* fix(package.json): @types/node-fetch should have been dev dependency

Author: darcyparker

bin/htmlhint

@@ -58,12 +58,13 @@
     }
   },
   "dependencies": {
+    "@types/node-fetch": "^2.5.12",
     "async": "3.2.0",
     "chalk": "4.1.0",
     "commander": "5.1.0",
     "glob": "7.1.7",
+    "node-fetch": "^2.6.2",
     "parse-glob": "3.0.4",
-    "request": "2.88.2",
     "strip-json-comments": "3.1.0",
     "xml": "1.0.1"
   },
@@ -80,8 +81,8 @@
     "@semantic-release/release-notes-generator": "9.0.3",
     "@types/async": "3.2.3",
     "@types/glob": "7.1.3",
+    "@types/node-fetch": "^2.5.12",
     "@types/parse-glob": "3.0.29",
-    "@types/request": "2.48.7",
     "@types/xml": "1.0.5",
     "@typescript-eslint/eslint-plugin": "3.6.0",
     "@typescript-eslint/parser": "3.6.0",

package-lock.json

@@ -8,7 +8,7 @@ import * as glob from 'glob'
 import { IGlob } from 'glob'
 import * as parseGlob from 'parse-glob'
 import { dirname, resolve, sep } from 'path'
-import * as request from 'request'
+import fetch from 'node-fetch'
 import * as stripJsonComments from 'strip-json-comments'
 import type { HTMLHint as IHTMLHint } from '../core/core'
 import type { Hint, Ruleset } from '../core/types'
@@ -494,12 +494,15 @@ function hintUrl(
   ruleset: Ruleset | undefined,
   callback: (messages: Hint[]) => void
 ) {
-  request.get(url, (error, response, body) => {
-    if (!error && response.statusCode == 200) {
-      const messages = HTMLHint.verify(body, ruleset)
-      callback(messages)
+  const errorFn = () => callback([])
+  fetch(url).then((response) => {
+    if (response.ok) {
+      response.text().then((body) => {
+        const messages = HTMLHint.verify(body, ruleset)
+        callback(messages)
+      }, errorFn)
     } else {
-      callback([])
+      errorFn()
     }
-  })
+  }, errorFn)
 }